content/renderer/history_controller.cc - Issue 2253053003: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/history_controller.cc

Issue 2253053003: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/history_controller.cc

diff --git a/content/renderer/history_controller.cc b/content/renderer/history_controller.cc

index dbdb11214fe277781b5e8f3857baf8952152aab7..0618765f8c8ff7bc0f7e8656f7512748e6c57efb 100644

--- a/content/renderer/history_controller.cc

+++ b/content/renderer/history_controller.cc

@@ -98,7 +98,7 @@ bool HistoryController::GoToEntry(

if (!render_frame)

continue;

render_frame->SetPendingNavigationParams(

- base::WrapUnique(new NavigationParams(*navigation_params_.get())));

+ base::MakeUnique<NavigationParams>(*navigation_params_.get()));

WebURLRequest request = frame->toWebLocalFrame()->requestFromHistoryItem(

item.second, cache_policy);

frame->toWebLocalFrame()->load(

@@ -113,7 +113,7 @@ bool HistoryController::GoToEntry(

if (!render_frame)

continue;

render_frame->SetPendingNavigationParams(

- base::WrapUnique(new NavigationParams(*navigation_params_.get())));

+ base::MakeUnique<NavigationParams>(*navigation_params_.get()));

WebURLRequest request = frame->toWebLocalFrame()->requestFromHistoryItem(

item.second, cache_policy);

frame->toWebLocalFrame()->load(

@@ -304,7 +304,7 @@ WebHistoryItem HistoryController::GetItemForNewChildFrame(

RenderFrameImpl* frame) const {

if (navigation_params_.get()) {

frame->SetPendingNavigationParams(

- base::WrapUnique(new NavigationParams(*navigation_params_.get())));

+ base::MakeUnique<NavigationParams>(*navigation_params_.get()));

}

if (!current_entry_)

« no previous file with comments | « content/renderer/gpu/frame_swap_message_queue_unittest.cc ('k') | content/renderer/input/input_event_filter.cc » ('j') | no next file with comments »