Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2253053002: CSS: RuleFeature::clear clears all invalidation sets (Closed)

Created:
4 years, 4 months ago by Eric Willigers
Modified:
4 years, 4 months ago
Reviewers:
rune
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS: RuleFeature::clear clears all invalidation sets The recently added members m_universalSiblingInvalidationSet and m_nthInvalidationSet were not being cleared in RuleFeature::clear(). For consistency, we now also clear these members. BUG=624277 Committed: https://crrev.com/dae81dbb5e468db696af6994346b8e3acde7bb26 Cr-Commit-Position: refs/heads/master@{#413001}

Patch Set 1 #

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/invalidation/rule-change.html View 1 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Eric Willigers
4 years, 4 months ago (2016-08-17 12:28:50 UTC) #4
rune
lgtm This should be possible to test. If you replace a stylesheet with an :nth-selector ...
4 years, 4 months ago (2016-08-17 12:50:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253053002/20001
4 years, 4 months ago (2016-08-18 23:36:00 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-19 01:26:19 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 01:32:16 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dae81dbb5e468db696af6994346b8e3acde7bb26
Cr-Commit-Position: refs/heads/master@{#413001}

Powered by Google App Engine
This is Rietveld 408576698