Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 225303020: Remove unnecessary class forward declaration in WebViewImpl.h (Closed)

Created:
6 years, 8 months ago by gyuyoung-inactive
Modified:
6 years, 8 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove unnecessary class forward declaration in WebViewImpl.h As some CLs have passed ownership of member variables from WebViewImpl to own core class, some member variables have been removed in WebViewImpl.h. Thus, we don't need to keep forward class declaration in the WebViewImpl.h as well. This cl removes unnecessary forward declarations. Additionally there are already unnecessary forward declarations. Those are removed together. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171131

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M Source/web/WebViewImpl.h View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
gyuyoung-inactive
6 years, 8 months ago (2014-04-08 11:20:35 UTC) #1
gyuyoung-inactive
On 2014/04/08 11:20:35, gyuyoung wrote: Jochen, this patch passes trybots.
6 years, 8 months ago (2014-04-09 07:14:05 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-09 07:40:26 UTC) #3
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 8 months ago (2014-04-09 07:54:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/225303020/1
6 years, 8 months ago (2014-04-09 07:54:38 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-09 08:32:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-09 08:32:44 UTC) #7
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 8 months ago (2014-04-09 09:29:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/225303020/1
6 years, 8 months ago (2014-04-09 09:29:39 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 10:10:19 UTC) #10
Message was sent while issue was closed.
Change committed as 171131

Powered by Google App Engine
This is Rietveld 408576698