Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 225303016: Elim kRestorePopups (Closed)

Created:
6 years, 8 months ago by stevenjb
Modified:
6 years, 8 months ago
CC:
chromium-reviews, marja+watch_chromium.org
Visibility:
Public.

Description

Elim kRestorePopups This is currently unused and will complicate some in-progress re-factoring of Browser::Type and SessionService. BUG=360750 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262859

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -118 lines) Patch
M chrome/browser/defaults.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/defaults.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/sessions/better_session_restore_browsertest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/sessions/session_restore_browsertest.cc View 2 chunks +0 lines, -48 lines 0 comments Download
M chrome/browser/sessions/session_service.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sessions/session_service_unittest.cc View 2 chunks +0 lines, -56 lines 0 comments Download
M chrome/browser/ui/browser_window_state.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
stevenjb
6 years, 8 months ago (2014-04-07 23:17:46 UTC) #1
sky
LGTM
6 years, 8 months ago (2014-04-07 23:34:27 UTC) #2
stevenjb
The CQ bit was checked by stevenjb@chromium.org
6 years, 8 months ago (2014-04-09 20:54:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/225303016/1
6 years, 8 months ago (2014-04-09 20:54:45 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 23:45:05 UTC) #5
Message was sent while issue was closed.
Change committed as 262859

Powered by Google App Engine
This is Rietveld 408576698