Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: Source/web/WebViewImpl.h

Issue 225303014: [Pinch-to-zoom] Moved scale factor into PinchViewport (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed layout test breakage Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebInputEventConversion.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebViewImpl.h
diff --git a/Source/web/WebViewImpl.h b/Source/web/WebViewImpl.h
index 41040d5a9004aa9424d4c9ce01f2c34cface6143..81f3a8125e2a5f9df8373ab72db7567f8c47f61a 100644
--- a/Source/web/WebViewImpl.h
+++ b/Source/web/WebViewImpl.h
@@ -179,9 +179,11 @@ public:
virtual void setInitialPageScaleOverride(float) OVERRIDE;
virtual bool zoomToMultipleTargetsRect(const WebRect&) OVERRIDE;
virtual float pageScaleFactor() const OVERRIDE;
- virtual void setPageScaleFactorPreservingScrollOffset(float) OVERRIDE;
- virtual void setPageScaleFactor(float scaleFactor, const WebPoint& origin) OVERRIDE;
virtual void setPageScaleFactorLimits(float minPageScale, float maxPageScale) OVERRIDE;
+ virtual void setMainFrameScrollOffset(const WebPoint&) OVERRIDE;
+ virtual void setPageScaleFactor(float) OVERRIDE;
+ virtual void setPinchViewportOffset(const WebFloatPoint&) OVERRIDE;
+ virtual WebFloatPoint pinchViewportOffset() const OVERRIDE;
virtual float minimumPageScaleFactor() const OVERRIDE;
virtual float maximumPageScaleFactor() const OVERRIDE;
virtual void saveScrollAndScaleState() OVERRIDE;
@@ -485,6 +487,12 @@ public:
WebLayerTreeView* layerTreeView() const { return m_layerTreeView; }
private:
+ // TODO(bokan): Remains for legacy pinch. Remove once it's gone. Made private to
+ // prevent external usage
+ virtual void setPageScaleFactor(float scaleFactor, const WebPoint& origin) OVERRIDE;
+
+ bool pinchVirtualViewportEnabled() const;
+
float legibleScale() const;
void refreshPageScaleFactorAfterLayout();
void resumeTreeViewCommits();
« no previous file with comments | « Source/web/WebInputEventConversion.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698