Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2298)

Unified Diff: Source/web/FullscreenController.cpp

Issue 225303014: [Pinch-to-zoom] Moved scale factor into PinchViewport (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed layout test breakage Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/FullscreenController.h ('k') | Source/web/InspectorClientImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/FullscreenController.cpp
diff --git a/Source/web/FullscreenController.cpp b/Source/web/FullscreenController.cpp
index 46314cec88c3c525788b2744f65b5e065027667d..8f37f6e97f77fcfa675233918ec1d2669275f671 100644
--- a/Source/web/FullscreenController.cpp
+++ b/Source/web/FullscreenController.cpp
@@ -81,7 +81,8 @@ void FullscreenController::didEnterFullScreen()
if (!m_exitFullscreenPageScaleFactor) {
m_exitFullscreenPageScaleFactor = m_webViewImpl->pageScaleFactor();
m_exitFullscreenScrollOffset = m_webViewImpl->mainFrame()->scrollOffset();
- m_webViewImpl->setPageScaleFactorPreservingScrollOffset(1.0f);
+ m_exitFullscreenPinchViewportOffset = m_webViewImpl->pinchViewportOffset();
+ m_webViewImpl->setPageScaleFactor(1.0f);
}
FullscreenElementStack::from(*doc).webkitDidEnterFullScreenForElement(0);
@@ -126,8 +127,9 @@ void FullscreenController::didExitFullScreen()
if (FullscreenElementStack* fullscreen = FullscreenElementStack::fromIfExists(*doc)) {
if (fullscreen->webkitIsFullScreen()) {
if (m_exitFullscreenPageScaleFactor) {
- m_webViewImpl->setPageScaleFactor(m_exitFullscreenPageScaleFactor,
- WebPoint(m_exitFullscreenScrollOffset.width(), m_exitFullscreenScrollOffset.height()));
+ m_webViewImpl->setPageScaleFactor(m_exitFullscreenPageScaleFactor);
+ m_webViewImpl->setMainFrameScrollOffset(IntPoint(m_exitFullscreenScrollOffset));
+ m_webViewImpl->setPinchViewportOffset(m_exitFullscreenPinchViewportOffset);
m_exitFullscreenPageScaleFactor = 0;
m_exitFullscreenScrollOffset = IntSize();
}
« no previous file with comments | « Source/web/FullscreenController.h ('k') | Source/web/InspectorClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698