Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: Source/web/tests/ProgrammaticScrollTest.cpp

Issue 225303014: [Pinch-to-zoom] Moved scale factor into PinchViewport (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/tests/ProgrammaticScrollTest.cpp
diff --git a/Source/web/tests/ProgrammaticScrollTest.cpp b/Source/web/tests/ProgrammaticScrollTest.cpp
index 3d47b0d7bcfd0b1651fe43f0e4364c2c851ec42e..d39075ca24b63fb2580bdaf6bec7a9010383d96a 100644
--- a/Source/web/tests/ProgrammaticScrollTest.cpp
+++ b/Source/web/tests/ProgrammaticScrollTest.cpp
@@ -61,7 +61,8 @@ TEST_F(ProgrammaticScrollTest, RestoreScrollPositionAndViewStateWithScale)
LocalFrame* frame = webViewImpl->mainFrameImpl()->frame();
frame->loader().setLoadType(FrameLoadTypeBackForward);
- webViewImpl->setPageScaleFactor(3.0f, WebPoint(0, 500));
+ webViewImpl->setPinchViewportScaleFactor(3.0f);
+ webViewImpl->setMainFrameScrollOffset(WebPoint(0, 500));
frame->view()->setWasScrolledByUser(false);
frame->loader().currentItem()->setPageScaleFactor(2);
frame->loader().currentItem()->setScrollPoint(WebPoint(0, 200));
@@ -90,7 +91,8 @@ TEST_F(ProgrammaticScrollTest, RestoreScrollPositionAndViewStateWithoutScale)
LocalFrame* frame = webViewImpl->mainFrameImpl()->frame();
frame->loader().setLoadType(FrameLoadTypeBackForward);
- webViewImpl->setPageScaleFactor(3.0f, WebPoint(0, 500));
+ webViewImpl->setPinchViewportScaleFactor(3.0f);
+ webViewImpl->setMainFrameScrollOffset(WebPoint(0, 500));
frame->view()->setWasScrolledByUser(false);
frame->loader().currentItem()->setPageScaleFactor(0);
frame->loader().currentItem()->setScrollPoint(WebPoint(0, 400));

Powered by Google App Engine
This is Rietveld 408576698