Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issue 225303011: Oilpan: fix build after r170943 (Closed)

Created:
6 years, 8 months ago by sof
Modified:
6 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/core/animation/StringKeyframe.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/StringKeyframe.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
sof
Please take a look.
6 years, 8 months ago (2014-04-07 06:47:59 UTC) #1
haraken
LGTM
6 years, 8 months ago (2014-04-07 06:52:36 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 8 months ago (2014-04-07 07:03:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/225303011/1
6 years, 8 months ago (2014-04-07 07:03:07 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-07 07:34:19 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/core/animation/StringKeyframe.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-04-07 07:34:20 UTC) #6
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 8 months ago (2014-04-07 07:41:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/225303011/20001
6 years, 8 months ago (2014-04-07 07:41:11 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-07 07:56:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 8 months ago (2014-04-07 07:56:07 UTC) #10
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 8 months ago (2014-04-07 08:01:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/225303011/20001
6 years, 8 months ago (2014-04-07 08:01:10 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-07 08:39:37 UTC) #13
Message was sent while issue was closed.
Change committed as 170955

Powered by Google App Engine
This is Rietveld 408576698