Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 225303010: Oilpan: add Member<T>(RawPtr<U>) constructor. (Closed)

Created:
6 years, 8 months ago by sof
Modified:
6 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Oilpan: add Member<T>(RawPtr<U>) constructor. r170929 introduced code that constructs a std::pair with a transition type of OwnPtrWillBeMember<T> as the second component, from a value having the transition type OwnPtrWillBeRawPtr<T>. With Oilpan enabled, this requires an implicit conversion from RawPtr<T> to Member<T>, which isn't supported. Introduce it here by adding a Member<T> constructor from a given RawPtr<>. R= BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170942

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -15 lines) Patch
M Source/platform/heap/Handle.h View 2 chunks +24 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
Please take a look. Addressing the ToT compile failure with Oilpan enabled. (Verified to build ...
6 years, 8 months ago (2014-04-06 21:35:40 UTC) #1
haraken
LGTM
6 years, 8 months ago (2014-04-07 00:39:03 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 8 months ago (2014-04-07 04:00:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/225303010/1
6 years, 8 months ago (2014-04-07 04:00:24 UTC) #4
commit-bot: I haz the power
Change committed as 170942
6 years, 8 months ago (2014-04-07 04:09:54 UTC) #5
sof
6 years, 8 months ago (2014-04-07 05:38:42 UTC) #6
Message was sent while issue was closed.
Forgot to mention -- ToT compiled with g++-4.7 before this, but not with clang
and vc2013. 

The reason being, I suspect, that its std::pair is not that far along to c++11
and its use of "rvalue references" for make_pair(). But didn't chase down fully.

Powered by Google App Engine
This is Rietveld 408576698