LayoutTests/editing/selection/selection-invalid-offset.html - Issue 225303002: Let Selection.collapse remember a raw Position instead of a canonicalized one.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/selection/selection-invalid-offset.html

Issue 225303002: Let Selection.collapse remember a raw Position instead of a canonicalized one. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix setSelectedRange arguments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js ('k') | LayoutTests/editing/selection/selection-invalid-offset-expected.txt » ('j') | Source/core/editing/FrameSelection.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <body>	1 <body>

2 You should see six OKs below (and not hang): <br>	2 You should see 7 OKs below (and not hang): <br>

3 <script>	3 <script>

4 if (window.testRunner)	4 if (window.testRunner)

5 testRunner.dumpAsText();	5 testRunner.dumpAsText();

6 var body = document.body;	6 var body = document.body;

7 var selection = window.getSelection();	7 var selection = window.getSelection();

8 try {

9 selection.collapse(body, -1);

10 } catch (e) {document.write(((e.code==DOMException.INDEX_SIZE_ERR) ? "OK" : "FAI L")+"<br>"); }

11	8

12 try {	9 function shouldThrowIndexSizeErrorException(script)

13 selection.setBaseAndExtent(body, -1, body, 0);	10 {

14 } catch (e) {document.write(((e.code==DOMException.INDEX_SIZE_ERR) ? "OK" : "FAI L")+"<br>"); }	11 try {

	12 eval(script);

	13 } catch (e) {

	14 document.write(((e.code == DOMException.INDEX_SIZE_ERR) ? "OK" : "FAIL") + "<br>");

	15 }

	16 }

15	17

16 try {	18 shouldThrowIndexSizeErrorException("selection.collapse(body, -1);");

17 selection.setBaseAndExtent(body, 0, body, -1);	19 shouldThrowIndexSizeErrorException("selection.setBaseAndExtent(body, -1, body, 0 );");

18 } catch (e) {document.write(((e.code==DOMException.INDEX_SIZE_ERR) ? "OK" : "FAI L")+"<br>"); }	20 shouldThrowIndexSizeErrorException("selection.setBaseAndExtent(body, 0, body, -1 );");

19	21 shouldThrowIndexSizeErrorException("selection.collapse(body, -1);");

20 try {	22 shouldThrowIndexSizeErrorException("selection.getRangeAt(-1);");

21 selection.collapse(body, -1);	23 shouldThrowIndexSizeErrorException("selection.getRangeAt(10000);");

22 } catch (e) {document.write(((e.code==DOMException.INDEX_SIZE_ERR) ? "OK" : "FAI L")+"<br>"); }	24 shouldThrowIndexSizeErrorException("selection.collapse(body, 10000);");

23

24 try {

25 selection.getRangeAt(-1);

26 } catch (e) {document.write(((e.code==DOMException.INDEX_SIZE_ERR) ? "OK" : "FAI L")+"<br>"); }

27

28 try {

29 selection.getRangeAt(10000);

30 } catch (e) {document.write(((e.code==DOMException.INDEX_SIZE_ERR) ? "OK" : "FAI L")+"<br>"); }

31	25

32 // these should throw as well but don't at the moment. Just checking they don't crash.	26 // these should throw as well but don't at the moment. Just checking they don't crash.

33 selection.collapse(body, 10000);

34 selection.setBaseAndExtent(body, 1000, body, 0);	27 selection.setBaseAndExtent(body, 1000, body, 0);

35 selection.setBaseAndExtent(body, 0, body, 10000);	28 selection.setBaseAndExtent(body, 0, body, 10000);

36 selection.collapse(body, 10000);

37 </script>	29 </script>

OLD	NEW