Second reland: Introduce mojo interface for collecting StackSamplingProfiler data

Second reland: Introduce mojo interface for collecting StackSamplingProfiler data

Adds interfaces, typemaps, and tests for collecting
StackSamplingProfiler result types. The collection interface will be
used to receive stack profiles from non-browser processes.

This change was previously reverted in
https://codereview.chromium.org/2264613002/ for introducing a skia
dependency that broke cronet. The dependency has been removed and the
new code has been split into independent targets.

BUG=517958
Committed: https://crrev.com/a6e65bb0cea385fc9fa82a5a1af4a5c3616e43e4
Committed: https://crrev.com/871f5628bf9ee3ee840e17bb65b8696a153b68eb
Cr-Original-Commit-Position: refs/heads/master@{#413285}
Cr-Commit-Position: refs/heads/master@{#413471}

[Mike Wittman, 2016-08-19 17:51:31]

The CQ bit was checked by wittman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 17:52:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 18:52:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 18:52:14]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Mike Wittman, 2016-08-19 19:40:53]

The CQ bit was checked by wittman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 19:49:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mike Wittman, 2016-08-19 21:13:49]

wittman@chromium.org changed reviewers:
+ isherman@chromium.org, sky@chromium.org, tsepez@google.com

[Mike Wittman, 2016-08-19 21:13:50]

Please take another look. Original CL in patch set 1.

Build changes in patch sets 2 and 3 remove the skia dep and move files to a
separate target by request of asvitkine.

isherman: BUILD.gn files
sky, tsepez: rubber stamp please

[Mike Wittman, 2016-08-19 21:14:57]

Description was changed from

==========
Reland Introduce mojo interface for collecting StackSamplingProfiler data

Adds interfaces, typemaps, and tests for collecting
StackSamplingProfiler result types. The collection interface will be
used to receive stack profiles from non-browser processes.

This change was previously reverted in
https://codereview.chromium.org/2264613002/ for introducing a skia
dependency that broke cronet. The dependency has been removed and the
new code has been split into independent targets.

BUG=517958
==========

to

==========
Reland Introduce mojo interface for collecting StackSamplingProfiler data

Adds interfaces, typemaps, and tests for collecting
StackSamplingProfiler result types. The collection interface will be
used to receive stack profiles from non-browser processes.

This change was previously reverted in
https://codereview.chromium.org/2264613002/ for introducing a skia
dependency that broke cronet. The dependency has been removed and the
new code has been split into independent targets.

BUG=517958
==========

[Mike Wittman, 2016-08-19 21:14:57]

wittman@chromium.org changed reviewers:
+ tsepez@chromium.org
- tsepez@google.com

[commit-bot: I haz the power, 2016-08-19 21:19:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 21:19:53]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-08-19 21:39:25]

still lgtm.

[sky, 2016-08-19 22:31:11]

LGTM

[Ilya Sherman, 2016-08-19 23:09:31]

LGTM % a nit:

https://codereview.chromium.org/2253013008/diff/40001/components/metrics/BUIL...
File components/metrics/BUILD.gn (right):

https://codereview.chromium.org/2253013008/diff/40001/components/metrics/BUIL...
components/metrics/BUILD.gn:337: }
Hmm, why did you move this to here?  If it can be in the more focused BUILD.gn
file, that would be better.

[Mike Wittman, 2016-08-19 23:27:54]

https://codereview.chromium.org/2253013008/diff/40001/components/metrics/BUIL...
File components/metrics/BUILD.gn (right):

https://codereview.chromium.org/2253013008/diff/40001/components/metrics/BUIL...
components/metrics/BUILD.gn:337: }
On 2016/08/19 23:09:31, Ilya Sherman wrote:
> Hmm, why did you move this to here?  If it can be in the more focused BUILD.gn
> file, that would be better.

The previous approach still transitively added the call_stack_unit_tests' own
deps to the unit_tests source set on iOS. This is a little cleaner since it
doesn't do that.

Either approach here is likely to be reworked substantially as this interface is
integrated into the metrics and chrome code, so it's probably not worth focusing
too finely on the details at the moment.

[Mike Wittman, 2016-08-19 23:28:20]

The CQ bit was checked by wittman@chromium.org

[commit-bot: I haz the power, 2016-08-19 23:29:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 23:34:16]

Description was changed from

==========
Reland Introduce mojo interface for collecting StackSamplingProfiler data

Adds interfaces, typemaps, and tests for collecting
StackSamplingProfiler result types. The collection interface will be
used to receive stack profiles from non-browser processes.

This change was previously reverted in
https://codereview.chromium.org/2264613002/ for introducing a skia
dependency that broke cronet. The dependency has been removed and the
new code has been split into independent targets.

BUG=517958
==========

to

==========
Reland Introduce mojo interface for collecting StackSamplingProfiler data

Adds interfaces, typemaps, and tests for collecting
StackSamplingProfiler result types. The collection interface will be
used to receive stack profiles from non-browser processes.

This change was previously reverted in
https://codereview.chromium.org/2264613002/ for introducing a skia
dependency that broke cronet. The dependency has been removed and the
new code has been split into independent targets.

BUG=517958
==========

[commit-bot: I haz the power, 2016-08-19 23:34:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-19 23:36:30]

Description was changed from

==========
Reland Introduce mojo interface for collecting StackSamplingProfiler data

Adds interfaces, typemaps, and tests for collecting
StackSamplingProfiler result types. The collection interface will be
used to receive stack profiles from non-browser processes.

This change was previously reverted in
https://codereview.chromium.org/2264613002/ for introducing a skia
dependency that broke cronet. The dependency has been removed and the
new code has been split into independent targets.

BUG=517958
==========

to

==========
Reland Introduce mojo interface for collecting StackSamplingProfiler data

Adds interfaces, typemaps, and tests for collecting
StackSamplingProfiler result types. The collection interface will be
used to receive stack profiles from non-browser processes.

This change was previously reverted in
https://codereview.chromium.org/2264613002/ for introducing a skia
dependency that broke cronet. The dependency has been removed and the
new code has been split into independent targets.

BUG=517958

Committed: https://crrev.com/a6e65bb0cea385fc9fa82a5a1af4a5c3616e43e4
Cr-Commit-Position: refs/heads/master@{#413285}
==========

[commit-bot: I haz the power, 2016-08-19 23:36:32]

Patchset 3 (id:??) landed as
https://crrev.com/a6e65bb0cea385fc9fa82a5a1af4a5c3616e43e4
Cr-Commit-Position: refs/heads/master@{#413285}

[alexmos, 2016-08-20 00:29:30]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2267483002/ by alexmos@chromium.org.

The reason for reverting is: Appears to break compile on Mac:
https://build.chromium.org/p/chromium/builders/Mac/builds/18700/

Error:
[10847/43976] LIBTOOL-STATIC obj/components/metrics/libcall_stacks.a
FAILED: obj/components/metrics/libcall_stacks.a 
rm -f obj/components/metrics/libcall_stacks.a && TOOL_VERSION=1468839730 python
../../build/toolchain/mac/filter_libtool.py libtool -static  -o
obj/components/metrics/libcall_stacks.a 
error:
/Applications/Xcode5.1.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool:
no files specified
.

[Mike Wittman, 2016-08-22 16:28:31]

Description was changed from

==========
Reland Introduce mojo interface for collecting StackSamplingProfiler data

Adds interfaces, typemaps, and tests for collecting
StackSamplingProfiler result types. The collection interface will be
used to receive stack profiles from non-browser processes.

This change was previously reverted in
https://codereview.chromium.org/2264613002/ for introducing a skia
dependency that broke cronet. The dependency has been removed and the
new code has been split into independent targets.

BUG=517958

Committed: https://crrev.com/a6e65bb0cea385fc9fa82a5a1af4a5c3616e43e4
Cr-Commit-Position: refs/heads/master@{#413285}
==========

to

==========
Reland Introduce mojo interface for collecting StackSamplingProfiler data

Adds interfaces, typemaps, and tests for collecting
StackSamplingProfiler result types. The collection interface will be
used to receive stack profiles from non-browser processes.

This change was previously reverted in
https://codereview.chromium.org/2264613002/ for introducing a skia
dependency that broke cronet. The dependency has been removed and the
new code has been split into independent targets.

BUG=517958

Committed: https://crrev.com/a6e65bb0cea385fc9fa82a5a1af4a5c3616e43e4
Cr-Commit-Position: refs/heads/master@{#413285}
==========

[Mike Wittman, 2016-08-22 16:35:14]

Apparently the Mac official build doesn't like static libraries containing only
mojo bindings. Attempting to reland with the target changed to a source_set.

[Mike Wittman, 2016-08-22 16:35:24]

The CQ bit was checked by wittman@chromium.org

[Mike Wittman, 2016-08-22 16:35:25]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
isherman@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2253013008/#ps60001
(title: "use source_set for call_stacks target")

[Mike Wittman, 2016-08-22 16:35:38]

The CQ bit was unchecked by wittman@chromium.org

[Mike Wittman, 2016-08-22 16:36:16]

Description was changed from

==========
Reland Introduce mojo interface for collecting StackSamplingProfiler data

Adds interfaces, typemaps, and tests for collecting
StackSamplingProfiler result types. The collection interface will be
used to receive stack profiles from non-browser processes.

This change was previously reverted in
https://codereview.chromium.org/2264613002/ for introducing a skia
dependency that broke cronet. The dependency has been removed and the
new code has been split into independent targets.

BUG=517958

Committed: https://crrev.com/a6e65bb0cea385fc9fa82a5a1af4a5c3616e43e4
Cr-Commit-Position: refs/heads/master@{#413285}
==========

to

==========
Second reland: Introduce mojo interface for collecting StackSamplingProfiler
data

Adds interfaces, typemaps, and tests for collecting
StackSamplingProfiler result types. The collection interface will be
used to receive stack profiles from non-browser processes.

This change was previously reverted in
https://codereview.chromium.org/2264613002/ for introducing a skia
dependency that broke cronet. The dependency has been removed and the
new code has been split into independent targets.

BUG=517958

Committed: https://crrev.com/a6e65bb0cea385fc9fa82a5a1af4a5c3616e43e4
Cr-Commit-Position: refs/heads/master@{#413285}
==========

[Mike Wittman, 2016-08-22 16:36:28]

The CQ bit was checked by wittman@chromium.org

[commit-bot: I haz the power, 2016-08-22 16:37:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 17:50:15]

Description was changed from

==========
Second reland: Introduce mojo interface for collecting StackSamplingProfiler
data

Adds interfaces, typemaps, and tests for collecting
StackSamplingProfiler result types. The collection interface will be
used to receive stack profiles from non-browser processes.

This change was previously reverted in
https://codereview.chromium.org/2264613002/ for introducing a skia
dependency that broke cronet. The dependency has been removed and the
new code has been split into independent targets.

BUG=517958

Committed: https://crrev.com/a6e65bb0cea385fc9fa82a5a1af4a5c3616e43e4
Cr-Commit-Position: refs/heads/master@{#413285}
==========

to

==========
Second reland: Introduce mojo interface for collecting StackSamplingProfiler
data

Adds interfaces, typemaps, and tests for collecting
StackSamplingProfiler result types. The collection interface will be
used to receive stack profiles from non-browser processes.

This change was previously reverted in
https://codereview.chromium.org/2264613002/ for introducing a skia
dependency that broke cronet. The dependency has been removed and the
new code has been split into independent targets.

BUG=517958

Committed: https://crrev.com/a6e65bb0cea385fc9fa82a5a1af4a5c3616e43e4
Cr-Commit-Position: refs/heads/master@{#413285}
==========

[commit-bot: I haz the power, 2016-08-22 17:50:17]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-22 17:53:17]

Description was changed from

==========
Second reland: Introduce mojo interface for collecting StackSamplingProfiler
data

Adds interfaces, typemaps, and tests for collecting
StackSamplingProfiler result types. The collection interface will be
used to receive stack profiles from non-browser processes.

This change was previously reverted in
https://codereview.chromium.org/2264613002/ for introducing a skia
dependency that broke cronet. The dependency has been removed and the
new code has been split into independent targets.

BUG=517958

Committed: https://crrev.com/a6e65bb0cea385fc9fa82a5a1af4a5c3616e43e4
Cr-Commit-Position: refs/heads/master@{#413285}
==========

to

==========
Second reland: Introduce mojo interface for collecting StackSamplingProfiler
data

Adds interfaces, typemaps, and tests for collecting
StackSamplingProfiler result types. The collection interface will be
used to receive stack profiles from non-browser processes.

This change was previously reverted in
https://codereview.chromium.org/2264613002/ for introducing a skia
dependency that broke cronet. The dependency has been removed and the
new code has been split into independent targets.

BUG=517958

Committed: https://crrev.com/a6e65bb0cea385fc9fa82a5a1af4a5c3616e43e4
Committed: https://crrev.com/871f5628bf9ee3ee840e17bb65b8696a153b68eb
Cr-Original-Commit-Position: refs/heads/master@{#413285}
Cr-Commit-Position: refs/heads/master@{#413471}
==========

[commit-bot: I haz the power, 2016-08-22 17:53:18]

Patchset 4 (id:??) landed as
https://crrev.com/871f5628bf9ee3ee840e17bb65b8696a153b68eb
Cr-Commit-Position: refs/heads/master@{#413471}