Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2253003002: Make libusb deprecation warning go away on OSX 10.12. (Closed)

Created:
4 years, 4 months ago by pwnall
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make libusb deprecation warning go away on OSX 10.12. BUG=638536 Committed: https://crrev.com/f08e1fbbbff62e9d8fa8b985986dcefcbb481293 Cr-Commit-Position: refs/heads/master@{#412628}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M third_party/libusb/BUILD.gn View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
pwnall
This is one of the few errors I get when trying to build Chromium on ...
4 years, 4 months ago (2016-08-17 10:06:15 UTC) #2
Reilly Grant (use Gerrit)
lgtm
4 years, 4 months ago (2016-08-17 17:44:47 UTC) #7
pwnall
On 2016/08/17 17:44:47, Reilly Grant wrote: > lgtm Thank you for the quick feedback!
4 years, 4 months ago (2016-08-17 20:11:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253003002/1
4 years, 4 months ago (2016-08-17 20:11:24 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 20:16:43 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 20:21:23 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f08e1fbbbff62e9d8fa8b985986dcefcbb481293
Cr-Commit-Position: refs/heads/master@{#412628}

Powered by Google App Engine
This is Rietveld 408576698