Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2252973002: Remove m_paragraphRange from SpellCheckRequest (Closed)

Created:
4 years, 4 months ago by Xiaocheng
Modified:
4 years, 4 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@SpellCheckerDebugInfo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove paragraph range from SpellCheckRequest |m_paragraphRange| is a redundant member of SpellCheckRequest because it is always initiated with the same value as |m_checkingRange| [*]. So this patch removes this redundant member. [*] This claim was always true until revision r368035, where I allowed a |SpellCheckRequest| to have two different ranges for the first time, which is an unnecessary change, though. BUG=619452 TEST=n/a; no visible change Committed: https://crrev.com/922c87eb33d709ba9fb9332ecde0a1bcf72d86bf Cr-Commit-Position: refs/heads/master@{#412468}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -25 lines) Patch
M third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp View 1 8 chunks +4 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Xiaocheng
After some archaeology I am convinced that |SpellCheckRequest::m_paragraphRange| is completely redundant, and hence, removing it. ...
4 years, 4 months ago (2016-08-17 06:12:38 UTC) #9
yosin_UTC9
lgtm
4 years, 4 months ago (2016-08-17 06:23:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252973002/20001
4 years, 4 months ago (2016-08-17 07:11:15 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 07:33:31 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 07:36:54 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/922c87eb33d709ba9fb9332ecde0a1bcf72d86bf
Cr-Commit-Position: refs/heads/master@{#412468}

Powered by Google App Engine
This is Rietveld 408576698