Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2252963005: DevTools: do not perform postponed search if the search was canceled (Closed)

Created:
4 years, 4 months ago by lushnikov
Modified:
4 years, 4 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: do not perform postponed search if the search was canceled BUG=none R=dgozman Committed: https://crrev.com/b6e3c9a7fd61c335c1878d033d1fa2bc9a69d952 Cr-Commit-Position: refs/heads/master@{#412726}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
lushnikov
please, take a look!
4 years, 4 months ago (2016-08-18 01:57:35 UTC) #1
dgozman
lgtm
4 years, 4 months ago (2016-08-18 01:59:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252963005/1
4 years, 4 months ago (2016-08-18 02:00:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 03:52:20 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 03:56:04 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b6e3c9a7fd61c335c1878d033d1fa2bc9a69d952
Cr-Commit-Position: refs/heads/master@{#412726}

Powered by Google App Engine
This is Rietveld 408576698