Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 225293010: [NaCl SDK] nacl_io: Fix newlib IRT interception of isatty(). (Closed)

Created:
6 years, 8 months ago by Sam Clegg
Modified:
6 years, 8 months ago
Reviewers:
binji
CC:
chromium-reviews, binji
Visibility:
Public.

Description

[NaCl SDK] nacl_io: Fix newlib IRT interception of isatty(). R=binji@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262821

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M native_client_sdk/src/libraries/nacl_io/kernel_wrap_newlib.cc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/tests/nacl_io_test/kernel_wrap_test.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sam Clegg
6 years, 8 months ago (2014-04-08 21:00:11 UTC) #1
binji
lgtm
6 years, 8 months ago (2014-04-08 21:02:48 UTC) #2
Sam Clegg
6 years, 8 months ago (2014-04-09 21:20:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r262821 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698