Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2252913003: Force recalc of the keyloop for alerts. (Closed)

Created:
4 years, 4 months ago by Avi (use Gerrit)
Modified:
4 years, 4 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Force recalc of the keyloop for alerts. BUG=638492, 383820 TEST=javascript:prompt("hi") Committed: https://crrev.com/5cd8a4ffe3f7262c8da2b7878c9766787afc09c8 Cr-Commit-Position: refs/heads/master@{#412622}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Avi (use Gerrit)
4 years, 4 months ago (2016-08-17 16:28:47 UTC) #7
Mark Mentovai
LGTM
4 years, 4 months ago (2016-08-17 19:54:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252913003/1
4 years, 4 months ago (2016-08-17 19:56:03 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 20:04:30 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 20:10:11 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5cd8a4ffe3f7262c8da2b7878c9766787afc09c8
Cr-Commit-Position: refs/heads/master@{#412622}

Powered by Google App Engine
This is Rietveld 408576698