Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: test/cctest/compiler/value-helper.h

Issue 2252863003: [turbofan] Add Float32(Max|Min) machine operators. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Improved tests and fixed a bug Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/compiler/value-helper.h
diff --git a/test/cctest/compiler/value-helper.h b/test/cctest/compiler/value-helper.h
index cdc7e658cb068fcf903f102dd65250176f361146..297bccb05bac604b77f240178f96145ba60c3478 100644
--- a/test/cctest/compiler/value-helper.h
+++ b/test/cctest/compiler/value-helper.h
@@ -332,6 +332,7 @@ static inline void CheckFloatEq(volatile float x, volatile float y) {
CHECK(std::isnan(y));
} else {
CHECK_EQ(x, y);
+ CHECK_EQ(std::signbit(x), std::signbit(y));
}
}
@@ -346,6 +347,7 @@ static inline void CheckDoubleEq(volatile double x, volatile double y) {
CHECK(std::isnan(y));
} else {
CHECK_EQ(x, y);
+ CHECK_EQ(std::signbit(x), std::signbit(y));
}
}

Powered by Google App Engine
This is Rietveld 408576698