Issue 2252853003: Removing valueOf from enum -keep

Issue 2252853003: Removing valueOf from enum -keep (Closed)

Created:
4 years, 4 months ago by smaier

Modified:
4 years, 4 months ago

Reviewers:
Yaron, xunjieli

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Removing valueOf from enum -keep This seems to be the way enum -keeps work for all other apps. BUG=619937 Committed: https://crrev.com/c433f858704d8a446f3c662a9d3c768e7515ede7 Cr-Commit-Position: refs/heads/master@{#412657}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	base/android/base_proguard_config.flags	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 11 (5 generated)

xunjieli

LGTM (though I am not a base OWNER). Thanks for taking care of this!

4 years, 4 months ago (2016-08-17 19:33:02 UTC) #4

Yaron

On 2016/08/17 19:33:02, xunjieli wrote: > LGTM (though I am not a base OWNER). Thanks ...

4 years, 4 months ago (2016-08-17 21:10:31 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252853003/1

4 years, 4 months ago (2016-08-17 21:12:03 UTC) #7

commit-bot: I haz the power

4 years, 4 months ago (2016-08-17 21:57:49 UTC) #11

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c433f858704d8a446f3c662a9d3c768e7515ede7
Cr-Commit-Position: refs/heads/master@{#412657}