Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2252833003: [ios] Use range.length instead of range.location for substring matching. (Closed)

Created:
4 years, 4 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 4 months ago
Reviewers:
Jackie Quinn
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Use range.length instead of range.location for substring matching. NSObject.description is not nullable and may return nil. In which case gesture recognizer should not be matched. BUG=None Committed: https://crrev.com/1cf5fe3f424969cf87edeebd351d697a8ed08aaf Cr-Commit-Position: refs/heads/master@{#412593}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Eugene But (OOO till 7-30)
4 years, 4 months ago (2016-08-17 18:23:38 UTC) #4
Jackie Quinn
lgtm
4 years, 4 months ago (2016-08-17 18:26:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252833003/1
4 years, 4 months ago (2016-08-17 18:26:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 18:31:09 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 18:38:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1cf5fe3f424969cf87edeebd351d697a8ed08aaf
Cr-Commit-Position: refs/heads/master@{#412593}

Powered by Google App Engine
This is Rietveld 408576698