Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2252833002: Delete m_ExtHandle and RetainFont (Closed)

Created:
4 years, 4 months ago by npm
Modified:
4 years, 4 months ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Delete m_ExtHandle and RetainFont because they are not being used. CFX_SubstFont::m_ExtHandle is never assigned a value different from nullptr. Similarly, IFX_SystemFontInfo::RetainFont has two implementations. Both of these return nullptr, so this method is not needed. Committed: https://pdfium.googlesource.com/pdfium/+/b88b8e47fd7adc14c7aff048c0def0579bdd22dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -28 lines) Patch
M core/fxge/android/fx_android_font.h View 1 chunk +0 lines, -1 line 0 comments Download
M core/fxge/android/fx_android_font.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M core/fxge/ge/cfx_fontmapper.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/fxge/ge/fx_ge_font.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M core/fxge/ge/fx_ge_fontmap.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M core/fxge/ge/fx_ge_text.cpp View 2 chunks +4 lines, -8 lines 0 comments Download
M core/fxge/include/fx_font.h View 1 chunk +0 lines, -1 line 0 comments Download
M core/fxge/include/ifx_systemfontinfo.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
npm
PTAL
4 years, 4 months ago (2016-08-16 22:20:56 UTC) #7
Tom Sepez
lgtm
4 years, 4 months ago (2016-08-16 22:27:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252833002/1
4 years, 4 months ago (2016-08-16 22:37:01 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 22:37:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/b88b8e47fd7adc14c7aff048c0def0579bdd...

Powered by Google App Engine
This is Rietveld 408576698