Issue 225283014: Convert SkPicture's generation ID to a unique ID

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 225283014: Convert SkPicture's generation ID to a unique ID (Closed)

Created:
6 years, 8 months ago by robertphillips

Modified:
6 years, 8 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Convert SkPicture's generation ID to a unique ID This CL addresses linger code review comments on r14037 (Add generation ID to SkPicture https://codereview.chromium.org/222683002/) Committed: http://code.google.com/p/skia/source/detail?r=14079

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -41 lines)			Patch
M	include/core/SkPicture.h	View	3 chunks	+4 lines, -6 lines	0 comments	Download
M	include/core/SkTypes.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/core/SkPicture.cpp	View	4 chunks	+9 lines, -9 lines	0 comments	Download
M	src/gpu/GrLayerCache.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrLayerCache.cpp	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	tests/PictureTest.cpp	View	1 chunk	+20 lines, -20 lines	0 comments	Download

Total messages: 5 (0 generated)

robertphillips

The CQ bit was checked by robertphillips@google.com

6 years, 8 months ago (2014-04-07 18:25:58 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/225283014/1

6 years, 8 months ago (2014-04-07 18:26:09 UTC) #4

Message was sent while issue was closed.

Change committed as 14079