Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: src/handles.h

Issue 225283005: Return MaybeHandle from SetProperty. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/factory.cc ('k') | src/handles.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/handles.h
diff --git a/src/handles.h b/src/handles.h
index 74184685c81eb3f9dc48a81c499709ff25df684b..2dfe866be33665fc45078bd64d6651d8579cd816 100644
--- a/src/handles.h
+++ b/src/handles.h
@@ -68,8 +68,11 @@ class MaybeHandle {
location_ = reinterpret_cast<T**>(maybe_handle.location_);
}
+ INLINE(void Assert()) { ASSERT(location_ != NULL); }
+ INLINE(void Check()) { CHECK(location_ != NULL); }
+
INLINE(Handle<T> ToHandleChecked()) {
- CHECK(location_ != NULL);
+ Check();
return Handle<T>(location_);
}
@@ -291,11 +294,6 @@ void FlattenString(Handle<String> str);
// string.
Handle<String> FlattenGetString(Handle<String> str);
-Handle<Object> ForceSetProperty(Handle<JSObject> object,
- Handle<Object> key,
- Handle<Object> value,
- PropertyAttributes attributes);
-
Handle<Object> DeleteProperty(Handle<JSObject> object, Handle<Object> key);
Handle<Object> ForceDeleteProperty(Handle<JSObject> object, Handle<Object> key);
« no previous file with comments | « src/factory.cc ('k') | src/handles.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698