src/factory.cc - Issue 225283005: Return MaybeHandle from SetProperty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 225283005: Return MaybeHandle from SetProperty. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index d4f2fe7f0dc92c62a81d5b36890e8b2a15b0df74..7b8fa38fb7c2d27956506d697c5e4e0af5a4c709 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -811,7 +811,7 @@ Handle<JSObject> Factory::NewFunctionPrototype(Handle<JSFunction> function) {

JSObject::SetLocalPropertyIgnoreAttributes(prototype,

constructor_string(),

function,

- DONT_ENUM);

+ DONT_ENUM).Assert();

}

return prototype;

« no previous file with comments | « src/factory.h ('k') | src/handles.h » ('j') | no next file with comments »