src/debug.cc - Issue 225283005: Return MaybeHandle from SetProperty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug.cc

Issue 225283005: Return MaybeHandle from SetProperty. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/debug.cc

diff --git a/src/debug.cc b/src/debug.cc

index d7667f19c8b2d6ed0a5d7dc3b3705f7a8f37cd13..83e78a22baacfc935d38e636833c60e1cf0ebe8f 100644

--- a/src/debug.cc

+++ b/src/debug.cc

@@ -847,7 +847,7 @@ bool Debug::Load() {

Handle<String> key = isolate_->factory()->InternalizeOneByteString(

STATIC_ASCII_VECTOR("builtins"));

Handle<GlobalObject> global = Handle<GlobalObject>(context->global_object());

- RETURN_IF_EMPTY_HANDLE_VALUE(

+ RETURN_ON_EXCEPTION_VALUE(

isolate_,

JSReceiver::SetProperty(global,

key,

« no previous file with comments | « src/bootstrapper.cc ('k') | src/factory.h » ('j') | no next file with comments »