Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: src/runtime.h

Issue 225283005: Return MaybeHandle from SetProperty. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/runtime.h
diff --git a/src/runtime.h b/src/runtime.h
index 50181b684f1fd18cdbe782eee13b385242f8a12b..feb0bf4ad837b0da733b07f782afd6f4a5e1592a 100644
--- a/src/runtime.h
+++ b/src/runtime.h
@@ -827,7 +827,7 @@ class Runtime : public AllStatic {
Handle<Object> object,
uint32_t index);
- static Handle<Object> SetObjectProperty(
+ MUST_USE_RESULT static MaybeHandle<Object> SetObjectProperty(
Isolate* isolate,
Handle<Object> object,
Handle<Object> key,
@@ -835,8 +835,7 @@ class Runtime : public AllStatic {
PropertyAttributes attr,
StrictMode strict_mode);
- static Handle<Object> ForceSetObjectProperty(
- Isolate* isolate,
+ MUST_USE_RESULT static MaybeHandle<Object> ForceSetObjectProperty(
Handle<JSObject> object,
Handle<Object> key,
Handle<Object> value,
@@ -899,7 +898,7 @@ class Runtime : public AllStatic {
static void OutOfMemory();
// Used in runtime.cc and hydrogen's VisitArrayLiteral.
- static Handle<Object> CreateArrayLiteralBoilerplate(
+ static MaybeHandle<Object> CreateArrayLiteralBoilerplate(
Igor Sheludko 2014/04/04 10:58:19 MUST_USE_RESULT
Yang 2014/04/04 11:17:41 Done.
Isolate* isolate,
Handle<FixedArray> literals,
Handle<FixedArray> elements);

Powered by Google App Engine
This is Rietveld 408576698