Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: src/isolate.h

Issue 225283005: Return MaybeHandle from SetProperty. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/isolate.h
diff --git a/src/isolate.h b/src/isolate.h
index eabe58bb07f2c2a35f481a080850afc6acebd320..2e84a19a966dce81f473bd5c1c3cae33b6fb82d1 100644
--- a/src/isolate.h
+++ b/src/isolate.h
@@ -177,7 +177,7 @@ typedef ZoneList<Handle<Object> > ZoneObjectList;
#define ASSIGN_RETURN_ON_EXCEPTION(isolate, dst, call, T) \
ASSIGN_RETURN_ON_EXCEPTION_VALUE(isolate, dst, call, MaybeHandle<T>())
-#define RETURN_ON_EXCEPTION_VALUE(isolate, dst, call, value) \
+#define RETURN_ON_EXCEPTION_VALUE(isolate, call, value) \
do { \
if ((call).is_null()) { \
ASSERT((isolate)->has_pending_exception()); \
@@ -186,11 +186,11 @@ typedef ZoneList<Handle<Object> > ZoneObjectList;
} while (false)
#define RETURN_FAILURE_ON_EXCEPTION(isolate, call) \
- RETURN_ON_EXCEPTION_VALUE(isolate, dst, call, Failure::Exception())
+ RETURN_ON_EXCEPTION_VALUE(isolate, call, Failure::Exception())
#define RETURN_ON_EXCEPTION(isolate, call, T) \
RETURN_ON_EXCEPTION_VALUE( \
- isolate, dst, call, MaybeHandle<T>::Exception())
+ isolate, call, MaybeHandle<T>())
Igor Sheludko 2014/04/04 10:58:19 Now it fits one line.
Yang 2014/04/04 11:17:41 Done.
#define FOR_EACH_ISOLATE_ADDRESS_NAME(C) \

Powered by Google App Engine
This is Rietveld 408576698