Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Side by Side Diff: src/stub-cache.cc

Issue 225283005: Return MaybeHandle from SetProperty. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/scopeinfo.cc ('k') | src/uri.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 638 matching lines...) Expand 10 before | Expand all | Expand 10 after
649 649
650 RUNTIME_FUNCTION(MaybeObject*, StoreInterceptorProperty) { 650 RUNTIME_FUNCTION(MaybeObject*, StoreInterceptorProperty) {
651 HandleScope scope(isolate); 651 HandleScope scope(isolate);
652 ASSERT(args.length() == 3); 652 ASSERT(args.length() == 3);
653 StoreIC ic(IC::NO_EXTRA_FRAME, isolate); 653 StoreIC ic(IC::NO_EXTRA_FRAME, isolate);
654 Handle<JSObject> receiver = args.at<JSObject>(0); 654 Handle<JSObject> receiver = args.at<JSObject>(0);
655 Handle<Name> name = args.at<Name>(1); 655 Handle<Name> name = args.at<Name>(1);
656 Handle<Object> value = args.at<Object>(2); 656 Handle<Object> value = args.at<Object>(2);
657 ASSERT(receiver->HasNamedInterceptor()); 657 ASSERT(receiver->HasNamedInterceptor());
658 PropertyAttributes attr = NONE; 658 PropertyAttributes attr = NONE;
659 Handle<Object> result = JSObject::SetPropertyWithInterceptor( 659 Handle<Object> result;
660 receiver, name, value, attr, ic.strict_mode()); 660 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
661 RETURN_IF_EMPTY_HANDLE(isolate, result); 661 isolate, result,
662 JSObject::SetPropertyWithInterceptor(
663 receiver, name, value, attr, ic.strict_mode()));
662 return *result; 664 return *result;
663 } 665 }
664 666
665 667
666 RUNTIME_FUNCTION(MaybeObject*, KeyedLoadPropertyWithInterceptor) { 668 RUNTIME_FUNCTION(MaybeObject*, KeyedLoadPropertyWithInterceptor) {
667 HandleScope scope(isolate); 669 HandleScope scope(isolate);
668 Handle<JSObject> receiver = args.at<JSObject>(0); 670 Handle<JSObject> receiver = args.at<JSObject>(0);
669 ASSERT(args.smi_at(1) >= 0); 671 ASSERT(args.smi_at(1) >= 0);
670 uint32_t index = args.smi_at(1); 672 uint32_t index = args.smi_at(1);
671 Handle<Object> result = 673 Handle<Object> result =
(...skipping 821 matching lines...) Expand 10 before | Expand all | Expand 10 after
1493 Handle<FunctionTemplateInfo>( 1495 Handle<FunctionTemplateInfo>(
1494 FunctionTemplateInfo::cast(signature->receiver())); 1496 FunctionTemplateInfo::cast(signature->receiver()));
1495 } 1497 }
1496 } 1498 }
1497 1499
1498 is_simple_api_call_ = true; 1500 is_simple_api_call_ = true;
1499 } 1501 }
1500 1502
1501 1503
1502 } } // namespace v8::internal 1504 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/scopeinfo.cc ('k') | src/uri.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698