Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Side by Side Diff: src/isolate.h

Issue 225283005: Return MaybeHandle from SetProperty. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ic.cc ('k') | src/isolate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 return value; \ 170 return value; \
171 } \ 171 } \
172 } while (false) 172 } while (false)
173 173
174 #define ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, dst, call) \ 174 #define ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, dst, call) \
175 ASSIGN_RETURN_ON_EXCEPTION_VALUE(isolate, dst, call, Failure::Exception()) 175 ASSIGN_RETURN_ON_EXCEPTION_VALUE(isolate, dst, call, Failure::Exception())
176 176
177 #define ASSIGN_RETURN_ON_EXCEPTION(isolate, dst, call, T) \ 177 #define ASSIGN_RETURN_ON_EXCEPTION(isolate, dst, call, T) \
178 ASSIGN_RETURN_ON_EXCEPTION_VALUE(isolate, dst, call, MaybeHandle<T>()) 178 ASSIGN_RETURN_ON_EXCEPTION_VALUE(isolate, dst, call, MaybeHandle<T>())
179 179
180 #define RETURN_ON_EXCEPTION_VALUE(isolate, dst, call, value) \ 180 #define RETURN_ON_EXCEPTION_VALUE(isolate, call, value) \
181 do { \ 181 do { \
182 if ((call).is_null()) { \ 182 if ((call).is_null()) { \
183 ASSERT((isolate)->has_pending_exception()); \ 183 ASSERT((isolate)->has_pending_exception()); \
184 return value; \ 184 return value; \
185 } \ 185 } \
186 } while (false) 186 } while (false)
187 187
188 #define RETURN_FAILURE_ON_EXCEPTION(isolate, call) \ 188 #define RETURN_FAILURE_ON_EXCEPTION(isolate, call) \
189 RETURN_ON_EXCEPTION_VALUE(isolate, dst, call, Failure::Exception()) 189 RETURN_ON_EXCEPTION_VALUE(isolate, call, Failure::Exception())
190 190
191 #define RETURN_ON_EXCEPTION(isolate, call, T) \ 191 #define RETURN_ON_EXCEPTION(isolate, call, T) \
192 RETURN_ON_EXCEPTION_VALUE( \ 192 RETURN_ON_EXCEPTION_VALUE(isolate, call, MaybeHandle<T>())
193 isolate, dst, call, MaybeHandle<T>::Exception())
194 193
195 194
196 #define FOR_EACH_ISOLATE_ADDRESS_NAME(C) \ 195 #define FOR_EACH_ISOLATE_ADDRESS_NAME(C) \
197 C(Handler, handler) \ 196 C(Handler, handler) \
198 C(CEntryFP, c_entry_fp) \ 197 C(CEntryFP, c_entry_fp) \
199 C(Context, context) \ 198 C(Context, context) \
200 C(PendingException, pending_exception) \ 199 C(PendingException, pending_exception) \
201 C(ExternalCaughtException, external_caught_exception) \ 200 C(ExternalCaughtException, external_caught_exception) \
202 C(JSEntrySP, js_entry_sp) 201 C(JSEntrySP, js_entry_sp)
203 202
(...skipping 1378 matching lines...) Expand 10 before | Expand all | Expand 10 after
1582 } 1581 }
1583 1582
1584 EmbeddedVector<char, 128> filename_; 1583 EmbeddedVector<char, 128> filename_;
1585 FILE* file_; 1584 FILE* file_;
1586 int scope_depth_; 1585 int scope_depth_;
1587 }; 1586 };
1588 1587
1589 } } // namespace v8::internal 1588 } } // namespace v8::internal
1590 1589
1591 #endif // V8_ISOLATE_H_ 1590 #endif // V8_ISOLATE_H_
OLDNEW
« no previous file with comments | « src/ic.cc ('k') | src/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698