Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: src/handles.cc

Issue 225283005: Return MaybeHandle from SetProperty. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/handles.h ('k') | src/hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 void FlattenString(Handle<String> string) { 151 void FlattenString(Handle<String> string) {
152 CALL_HEAP_FUNCTION_VOID(string->GetIsolate(), string->TryFlatten()); 152 CALL_HEAP_FUNCTION_VOID(string->GetIsolate(), string->TryFlatten());
153 } 153 }
154 154
155 155
156 Handle<String> FlattenGetString(Handle<String> string) { 156 Handle<String> FlattenGetString(Handle<String> string) {
157 CALL_HEAP_FUNCTION(string->GetIsolate(), string->TryFlatten(), String); 157 CALL_HEAP_FUNCTION(string->GetIsolate(), string->TryFlatten(), String);
158 } 158 }
159 159
160 160
161 Handle<Object> ForceSetProperty(Handle<JSObject> object,
162 Handle<Object> key,
163 Handle<Object> value,
164 PropertyAttributes attributes) {
165 return Runtime::ForceSetObjectProperty(object->GetIsolate(), object, key,
166 value, attributes);
167 }
168
169
170 Handle<Object> DeleteProperty(Handle<JSObject> object, Handle<Object> key) { 161 Handle<Object> DeleteProperty(Handle<JSObject> object, Handle<Object> key) {
171 Isolate* isolate = object->GetIsolate(); 162 Isolate* isolate = object->GetIsolate();
172 CALL_HEAP_FUNCTION(isolate, 163 CALL_HEAP_FUNCTION(isolate,
173 Runtime::DeleteObjectProperty( 164 Runtime::DeleteObjectProperty(
174 isolate, object, key, JSReceiver::NORMAL_DELETION), 165 isolate, object, key, JSReceiver::NORMAL_DELETION),
175 Object); 166 Object);
176 } 167 }
177 168
178 169
179 Handle<Object> ForceDeleteProperty(Handle<JSObject> object, 170 Handle<Object> ForceDeleteProperty(Handle<JSObject> object,
(...skipping 583 matching lines...) Expand 10 before | Expand all | Expand 10 after
763 Handle<Code> code) { 754 Handle<Code> code) {
764 heap->EnsureWeakObjectToCodeTable(); 755 heap->EnsureWeakObjectToCodeTable();
765 Handle<DependentCode> dep(heap->LookupWeakObjectToCodeDependency(*object)); 756 Handle<DependentCode> dep(heap->LookupWeakObjectToCodeDependency(*object));
766 dep = DependentCode::Insert(dep, DependentCode::kWeaklyEmbeddedGroup, code); 757 dep = DependentCode::Insert(dep, DependentCode::kWeaklyEmbeddedGroup, code);
767 CALL_HEAP_FUNCTION_VOID(heap->isolate(), 758 CALL_HEAP_FUNCTION_VOID(heap->isolate(),
768 heap->AddWeakObjectToCodeDependency(*object, *dep)); 759 heap->AddWeakObjectToCodeDependency(*object, *dep));
769 } 760 }
770 761
771 762
772 } } // namespace v8::internal 763 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/handles.h ('k') | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698