Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/debug.cc

Issue 225283005: Return MaybeHandle from SetProperty. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/bootstrapper.cc ('k') | src/factory.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 829 matching lines...) Expand 10 before | Expand all | Expand 10 after
840 if (context.is_null()) return false; 840 if (context.is_null()) return false;
841 841
842 // Use the debugger context. 842 // Use the debugger context.
843 SaveContext save(isolate_); 843 SaveContext save(isolate_);
844 isolate_->set_context(*context); 844 isolate_->set_context(*context);
845 845
846 // Expose the builtins object in the debugger context. 846 // Expose the builtins object in the debugger context.
847 Handle<String> key = isolate_->factory()->InternalizeOneByteString( 847 Handle<String> key = isolate_->factory()->InternalizeOneByteString(
848 STATIC_ASCII_VECTOR("builtins")); 848 STATIC_ASCII_VECTOR("builtins"));
849 Handle<GlobalObject> global = Handle<GlobalObject>(context->global_object()); 849 Handle<GlobalObject> global = Handle<GlobalObject>(context->global_object());
850 RETURN_IF_EMPTY_HANDLE_VALUE( 850 RETURN_ON_EXCEPTION_VALUE(
851 isolate_, 851 isolate_,
852 JSReceiver::SetProperty(global, 852 JSReceiver::SetProperty(global,
853 key, 853 key,
854 Handle<Object>(global->builtins(), isolate_), 854 Handle<Object>(global->builtins(), isolate_),
855 NONE, 855 NONE,
856 SLOPPY), 856 SLOPPY),
857 false); 857 false);
858 858
859 // Compile the JavaScript for the debugger in the debugger context. 859 // Compile the JavaScript for the debugger in the debugger context.
860 debugger->set_compiling_natives(true); 860 debugger->set_compiling_natives(true);
(...skipping 2950 matching lines...) Expand 10 before | Expand all | Expand 10 after
3811 { 3811 {
3812 Locker locker(reinterpret_cast<v8::Isolate*>(isolate_)); 3812 Locker locker(reinterpret_cast<v8::Isolate*>(isolate_));
3813 isolate_->debugger()->CallMessageDispatchHandler(); 3813 isolate_->debugger()->CallMessageDispatchHandler();
3814 } 3814 }
3815 } 3815 }
3816 } 3816 }
3817 3817
3818 #endif // ENABLE_DEBUGGER_SUPPORT 3818 #endif // ENABLE_DEBUGGER_SUPPORT
3819 3819
3820 } } // namespace v8::internal 3820 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/bootstrapper.cc ('k') | src/factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698