Updates to Ash material design icons used for TrayImageItem

Updates to Ash material design icons used for TrayImageItem

Update the following icons used in the Ash material
design system menu:

* Caps lock
* Auto rotation
* Auto rotation locked
* System update available

Furthermore, color the system update icon in the
system tray and system menu in response to the
severity of the update. The colors chosen for
each severity level match those used by the
system update icon in material design top chrome.

BUG=625690
TEST=manual

Committed: https://crrev.com/7804394b1833559f5cb96b7689e6e61f00f91510
Cr-Commit-Position: refs/heads/master@{#412609}

[tdanderson, 2016-08-16 21:10:23]

The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 21:10:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tdanderson, 2016-08-16 21:18:44]

tdanderson@chromium.org changed reviewers:
+ estade@chromium.org, jamescook@chromium.org

[tdanderson, 2016-08-16 21:18:45]

James and Evan, can you please take a look?

https://codereview.chromium.org/2252823002/diff/1/ash/common/system/tray/syst...
File ash/common/system/tray/system_tray_delegate.h (right):

https://codereview.chromium.org/2252823002/diff/1/ash/common/system/tray/syst...
ash/common/system/tray/system_tray_delegate.h:70: enum UpdateSeverity {
Any suggestions on how we can eliminate the need for this enum as well as
UpgradeNotificationAnnoyanceLevel ?

https://codereview.chromium.org/2252823002/diff/1/ash/common/system/update/tr...
File ash/common/system/update/tray_update.cc (right):

https://codereview.chromium.org/2252823002/diff/1/ash/common/system/update/tr...
ash/common/system/update/tray_update.cc:67: return for_menu ?
gfx::kGoogleGreen700 : gfx::kGoogleGreen300;
Any suggestions for the best place to put the color logic shared by this and
UpgradeDetector::GetIcon() ?

[Evan Stade, 2016-08-16 21:39:20]

https://codereview.chromium.org/2252823002/diff/1/ash/common/system/update/tr...
File ash/common/system/update/tray_update.cc (right):

https://codereview.chromium.org/2252823002/diff/1/ash/common/system/update/tr...
ash/common/system/update/tray_update.cc:67: return for_menu ?
gfx::kGoogleGreen700 : gfx::kGoogleGreen300;
On 2016/08/16 21:18:45, tdanderson wrote:
> Any suggestions for the best place to put the color logic shared by this and
> UpgradeDetector::GetIcon() ?

I'm not sure how we can get around separate switch statements because of the
different enums. However, it would be nice if we could do:

GetLowSeverityColor(bool dark_bg /*or SkColor bg_color*/)
GetHighSeverityColor(...)
etc.

I guess this would go in color_utils or color_palette?

Alternately it might make sense to put these into NativeTheme, and to set the
tray to use a NativeThemeDarkAura (same as incognito).

[James Cook, 2016-08-16 21:48:56]

LGTM

https://codereview.chromium.org/2252823002/diff/1/ash/common/system/tray/syst...
File ash/common/system/tray/system_tray_delegate.h (right):

https://codereview.chromium.org/2252823002/diff/1/ash/common/system/tray/syst...
ash/common/system/tray/system_tray_delegate.h:70: enum UpdateSeverity {
On 2016/08/16 21:18:45, tdanderson wrote:
> Any suggestions on how we can eliminate the need for this enum as well as
> UpgradeNotificationAnnoyanceLevel ?

You could create a shared header somewhere in //components, but I don't see a
good place for it. The cure might be worse than the disease.

You could static_assert something in system_tray_delegate_utils.cc about the
enums matching if you're worried about them drifting apart.

Sorry, no great thoughts.

[commit-bot: I haz the power, 2016-08-16 22:02:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 22:02:30]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-08-17 16:37:11]

On 2016/08/16 21:48:56, James Cook (slow reviews) wrote:
> LGTM
> 
>
https://codereview.chromium.org/2252823002/diff/1/ash/common/system/tray/syst...
> File ash/common/system/tray/system_tray_delegate.h (right):
> 
>
https://codereview.chromium.org/2252823002/diff/1/ash/common/system/tray/syst...
> ash/common/system/tray/system_tray_delegate.h:70: enum UpdateSeverity {
> On 2016/08/16 21:18:45, tdanderson wrote:
> > Any suggestions on how we can eliminate the need for this enum as well as
> > UpgradeNotificationAnnoyanceLevel ?
> 
> You could create a shared header somewhere in //components, but I don't see a
> good place for it. The cure might be worse than the disease.
> 
> You could static_assert something in system_tray_delegate_utils.cc about the
> enums matching if you're worried about them drifting apart.
> 
> Sorry, no great thoughts.

discussed on vc, native theme seems promising for future work, but this lgtm for
now

[tdanderson, 2016-08-17 17:02:50]

tdanderson@chromium.org changed reviewers:
+ oshima@chromium.org

[tdanderson, 2016-08-17 17:02:50]

oshima@, can you please take a look at the change in chrome/ ?

[oshima, 2016-08-17 19:17:39]

lgtm

[tdanderson, 2016-08-17 19:17:56]

The CQ bit was checked by tdanderson@chromium.org

[commit-bot: I haz the power, 2016-08-17 19:18:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 19:23:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-17 19:27:35]

Description was changed from

==========
Updates to Ash material design icons used for TrayImageItem

Update the following icons used in the Ash material
design system menu:

* Caps lock
* Auto rotation
* Auto rotation locked
* System update available

Furthermore, color the system update icon in the
system tray and system menu in response to the
severity of the update. The colors chosen for
each severity level match those used by the
system update icon in material design top chrome.

BUG=625690
TEST=manual
==========

to

==========
Updates to Ash material design icons used for TrayImageItem

Update the following icons used in the Ash material
design system menu:

* Caps lock
* Auto rotation
* Auto rotation locked
* System update available

Furthermore, color the system update icon in the
system tray and system menu in response to the
severity of the update. The colors chosen for
each severity level match those used by the
system update icon in material design top chrome.

BUG=625690
TEST=manual

Committed: https://crrev.com/7804394b1833559f5cb96b7689e6e61f00f91510
Cr-Commit-Position: refs/heads/master@{#412609}
==========

[commit-bot: I haz the power, 2016-08-17 19:27:36]

Patchset 1 (id:??) landed as
https://crrev.com/7804394b1833559f5cb96b7689e6e61f00f91510
Cr-Commit-Position: refs/heads/master@{#412609}