Changelog tweaks

Changelog tweaks

Remove not on glibc upgrade - reverted
Moved tool notes above strong mode notes - more important to more people
Remove dart:io notes – bug fixes don't meet the bar for changelog

R=mit@google.com

Committed: https://github.com/dart-lang/sdk/commit/c1a0a039eec99907850169d3a90beb89630f8bba

[kevmoo, 2016-08-16 20:41:18]

kevmoo@google.com changed reviewers:
+ mit@google.com, whesse@google.com

[mit, 2016-08-17 10:42:48]

Added comments. Bill, can you confirm my C++ comment below?

https://codereview.chromium.org/2252803002/diff/1/CHANGELOG.md
File CHANGELOG.md (left):

https://codereview.chromium.org/2252803002/diff/1/CHANGELOG.md#oldcode14
CHANGELOG.md:14: * `Socket.connect` with source-address argument is now
non-blocking
This seems to be a behavioural change and not just a bugfix, so shouldn't we
keep this?

https://codereview.chromium.org/2252803002/diff/1/CHANGELOG.md#oldcode94
CHANGELOG.md:94: *   The dependency on BoringSSL has been rolled forward. Going
forward, builds
We did not revert the dependency on C++11, we just changed the builders to get a
more recent glibc without also getting a new OS. So we should keep this.

[Bill Hesse, 2016-08-17 11:32:47]

https://codereview.chromium.org/2252803002/diff/1/CHANGELOG.md
File CHANGELOG.md (left):

https://codereview.chromium.org/2252803002/diff/1/CHANGELOG.md#oldcode94
CHANGELOG.md:94: *   The dependency on BoringSSL has been rolled forward. Going
forward, builds
On 2016/08/17 10:42:48, mit wrote:
> We did not revert the dependency on C++11, we just changed the builders to get
a
> more recent glibc without also getting a new OS. So we should keep this.

Other way around, we got a new OS without getting a more recent glibc.
Glibc part should be dropped.  Just "will require a compiler with C++11
support".  Maybe we should also drop "including secure sockets", if we want to
start using C++11 elsewhere.

[kevmoo, 2016-08-17 17:26:22]

Also fixed some yaml formatting and version number for dart_style

https://codereview.chromium.org/2252803002/diff/1/CHANGELOG.md
File CHANGELOG.md (left):

https://codereview.chromium.org/2252803002/diff/1/CHANGELOG.md#oldcode14
CHANGELOG.md:14: * `Socket.connect` with source-address argument is now
non-blocking
On 2016/08/17 10:42:48, mit wrote:
> This seems to be a behavioural change and not just a bugfix, so shouldn't we
> keep this?

Leaving as is, per meeting discussion

https://codereview.chromium.org/2252803002/diff/1/CHANGELOG.md#oldcode94
CHANGELOG.md:94: *   The dependency on BoringSSL has been rolled forward. Going
forward, builds
On 2016/08/17 11:32:47, Bill Hesse wrote:
> On 2016/08/17 10:42:48, mit wrote:
> > We did not revert the dependency on C++11, we just changed the builders to
get
> a
> > more recent glibc without also getting a new OS. So we should keep this.
> 
> Other way around, we got a new OS without getting a more recent glibc.
> Glibc part should be dropped.  Just "will require a compiler with C++11
> support".  Maybe we should also drop "including secure sockets", if we want to
> start using C++11 elsewhere.

Done.

[mit, 2016-08-17 17:39:23]

On 2016/08/17 17:26:22, kevmoo wrote:
> Also fixed some yaml formatting and version number for dart_style
> 
> https://codereview.chromium.org/2252803002/diff/1/CHANGELOG.md
> File CHANGELOG.md (left):
> 
> https://codereview.chromium.org/2252803002/diff/1/CHANGELOG.md#oldcode14
> CHANGELOG.md:14: * `Socket.connect` with source-address argument is now
> non-blocking
> On 2016/08/17 10:42:48, mit wrote:
> > This seems to be a behavioural change and not just a bugfix, so shouldn't we
> > keep this?
> 
> Leaving as is, per meeting discussion
> 
> https://codereview.chromium.org/2252803002/diff/1/CHANGELOG.md#oldcode94
> CHANGELOG.md:94: *   The dependency on BoringSSL has been rolled forward.
Going
> forward, builds
> On 2016/08/17 11:32:47, Bill Hesse wrote:
> > On 2016/08/17 10:42:48, mit wrote:
> > > We did not revert the dependency on C++11, we just changed the builders to
> get
> > a
> > > more recent glibc without also getting a new OS. So we should keep this.
> > 
> > Other way around, we got a new OS without getting a more recent glibc.
> > Glibc part should be dropped.  Just "will require a compiler with C++11
> > support".  Maybe we should also drop "including secure sockets", if we want
to
> > start using C++11 elsewhere.
> 
> Done.

lgtm

[kevmoo, 2016-08-17 17:49:01]

Description was changed from

==========
Changelog tweaks

Remove not on glibc upgrade - reverted
Moved tool notes above strong mode notes - more important to more people
Remove dart:io notes – bug fixes don't meet the bar for changelog
==========

to

==========
Changelog tweaks

Remove not on glibc upgrade - reverted
Moved tool notes above strong mode notes - more important to more people
Remove dart:io notes – bug fixes don't meet the bar for changelog

R=mit@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c1a0a039eec99907850169d3a90beb89630f8bba
==========

[kevmoo, 2016-08-17 17:49:02]

Committed patchset #2 (id:20001) manually as
c1a0a039eec99907850169d3a90beb89630f8bba (presubmit successful).