Revert of Use a custom Struct for stack trace storage

src/objects.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_OBJECTS_H_
 #define V8_OBJECTS_H_
 
 #include <iosfwd>
 #include <memory>
 
@@ skipping 370 matching lines @@
   V(ACCESS_CHECK_INFO_TYPE)                                     \
   V(INTERCEPTOR_INFO_TYPE)                                      \
   V(CALL_HANDLER_INFO_TYPE)                                     \
   V(FUNCTION_TEMPLATE_INFO_TYPE)                                \
   V(OBJECT_TEMPLATE_INFO_TYPE)                                  \
   V(SIGNATURE_INFO_TYPE)                                        \
   V(TYPE_SWITCH_INFO_TYPE)                                      \
   V(ALLOCATION_MEMENTO_TYPE)                                    \
   V(ALLOCATION_SITE_TYPE)                                       \
   V(SCRIPT_TYPE)                                                \
-  V(STACK_TRACE_FRAME_TYPE)                                     \
   V(TYPE_FEEDBACK_INFO_TYPE)                                    \
   V(ALIASED_ARGUMENTS_ENTRY_TYPE)                               \
   V(BOX_TYPE)                                                   \
   V(PROTOTYPE_INFO_TYPE)                                        \
   V(SLOPPY_BLOCK_WITH_EVAL_CONTEXT_EXTENSION_TYPE)              \
                                                                 \
   V(FIXED_ARRAY_TYPE)                                           \
   V(FIXED_DOUBLE_ARRAY_TYPE)                                    \
   V(SHARED_FUNCTION_INFO_TYPE)                                  \
   V(WEAK_CELL_TYPE)                                             \
@@ skipping 95 matching lines @@
 #define STRUCT_LIST(V)                                                       \
   V(BOX, Box, box)                                                           \
   V(ACCESSOR_INFO, AccessorInfo, accessor_info)                              \
   V(ACCESSOR_PAIR, AccessorPair, accessor_pair)                              \
   V(ACCESS_CHECK_INFO, AccessCheckInfo, access_check_info)                   \
   V(INTERCEPTOR_INFO, InterceptorInfo, interceptor_info)                     \
   V(CALL_HANDLER_INFO, CallHandlerInfo, call_handler_info)                   \
   V(FUNCTION_TEMPLATE_INFO, FunctionTemplateInfo, function_template_info)    \
   V(OBJECT_TEMPLATE_INFO, ObjectTemplateInfo, object_template_info)          \
   V(SCRIPT, Script, script)                                                  \
-  V(STACK_TRACE_FRAME, StackTraceFrame, stack_trace_frame)                   \
   V(ALLOCATION_SITE, AllocationSite, allocation_site)                        \
   V(ALLOCATION_MEMENTO, AllocationMemento, allocation_memento)               \
   V(TYPE_FEEDBACK_INFO, TypeFeedbackInfo, type_feedback_info)                \
   V(ALIASED_ARGUMENTS_ENTRY, AliasedArgumentsEntry, aliased_arguments_entry) \
   V(DEBUG_INFO, DebugInfo, debug_info)                                       \
   V(BREAK_POINT_INFO, BreakPointInfo, break_point_info)                      \
   V(PROTOTYPE_INFO, PrototypeInfo, prototype_info)                           \
   V(SLOPPY_BLOCK_WITH_EVAL_CONTEXT_EXTENSION,                                \
     SloppyBlockWithEvalContextExtension,                                     \
     sloppy_block_with_eval_context_extension)
@@ skipping 151 matching lines @@
   ACCESS_CHECK_INFO_TYPE,
   INTERCEPTOR_INFO_TYPE,
   CALL_HANDLER_INFO_TYPE,
   FUNCTION_TEMPLATE_INFO_TYPE,
   OBJECT_TEMPLATE_INFO_TYPE,
   SIGNATURE_INFO_TYPE,
   TYPE_SWITCH_INFO_TYPE,
   ALLOCATION_SITE_TYPE,
   ALLOCATION_MEMENTO_TYPE,
   SCRIPT_TYPE,
-  STACK_TRACE_FRAME_TYPE,
   TYPE_FEEDBACK_INFO_TYPE,
   ALIASED_ARGUMENTS_ENTRY_TYPE,
   BOX_TYPE,
   DEBUG_INFO_TYPE,
   BREAK_POINT_INFO_TYPE,
   FIXED_ARRAY_TYPE,
   SHARED_FUNCTION_INFO_TYPE,
   CELL_TYPE,
   WEAK_CELL_TYPE,
   TRANSITION_ARRAY_TYPE,
@@ skipping 5797 matching lines @@
   DECLARE_PRINTER(Box)
   DECLARE_VERIFIER(Box)
 
   static const int kValueOffset = HeapObject::kHeaderSize;
   static const int kSize = kValueOffset + kPointerSize;
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(Box);
 };
 
+
 // Container for metadata stored on each prototype map.
 class PrototypeInfo : public Struct {
  public:
   static const int UNREGISTERED = -1;
 
   // [prototype_users]: WeakFixedArray containing maps using this prototype,
   // or Smi(0) if uninitialized.
   DECL_ACCESSORS(prototype_users, Object)
 
   // [object_create_map]: A field caching the map for Object.create(prototype).
@@ skipping 264 matching lines @@
   static const int kCompilationStateBit = 1;
   static const int kHideSourceBit = 2;
   static const int kOriginOptionsShift = 3;
   static const int kOriginOptionsSize = 3;
   static const int kOriginOptionsMask = ((1 << kOriginOptionsSize) - 1)
                                         << kOriginOptionsShift;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(Script);
 };
 
-class StackTraceFrame : public Struct {
- public:
-  // --- Fields for JS and Wasm frames. ---
-
-  static const int kIsWasmFrame = 1 << 0;
-  static const int kForceConstructor = 1 << 1;
-  static const int kIsStrict = 1 << 2;
-
-  // [flags]
-  DECL_INT_ACCESSORS(flags)
-
-  // [abstract_code]
-  DECL_ACCESSORS(abstract_code, AbstractCode)
-
-  // [offset]
-  DECL_INT_ACCESSORS(offset)
-
-  // --- Fields for JS frames. ---
-
-  // [receiver]
-  DECL_ACCESSORS(receiver, Object)
-
-  // [function]
-  DECL_ACCESSORS(function, JSFunction)
-
-  // --- Fields for Wasm frames. ---
-
-  // [wasm_object]
-  DECL_ACCESSORS(wasm_object, Object)
-
-  // [wasm_function_index]
-  DECL_INT_ACCESSORS(wasm_function_index)
-
-  inline bool IsWasmFrame() const;
-  inline bool IsJavaScriptFrame() const;
-  inline bool IsStrict() const;
-  inline bool ForceConstructor() const;
-
-  Handle<Object> GetFileName();
-  Handle<Object> GetFunctionName();
-  Handle<Object> GetScriptNameOrSourceUrl();
-  Handle<Object> GetMethodName();
-  Handle<Object> GetTypeName();
-  Handle<Object> GetEvalOrigin();
-
-  int GetPosition();
-  // Return 1-based line number, including line offset.
-  int GetLineNumber();
-  // Return 1-based column number, including column offset if first line.
-  int GetColumnNumber();
-
-  bool IsNative();
-  bool IsToplevel();
-  bool IsEval();
-  bool IsConstructor();
-
-  Handle<String> ToString();
-
-  DECLARE_CAST(StackTraceFrame)
-
-  // Dispatched behavior.
-  DECLARE_PRINTER(StackTraceFrame)
-  DECLARE_VERIFIER(StackTraceFrame)
-
-  // Fields for all frame types.
-  static const int kFlagsOffset = HeapObject::kHeaderSize;
-  static const int kAbstractCodeOffset = kFlagsOffset + kPointerSize;
-  static const int kOffsetOffset = kAbstractCodeOffset + kPointerSize;
-
-  // Fields for JS frames.
-  static const int kReceiverOffset = kOffsetOffset + kPointerSize;
-  static const int kFunctionOffset = kReceiverOffset + kPointerSize;
-
-  // Fields for Wasm frames.
-  static const int kWasmObjectOffset = kOffsetOffset + kPointerSize;
-  static const int kWasmFunctionIndexOffset = kWasmObjectOffset + kPointerSize;
-
-  static const int kSize = kFunctionOffset + kPointerSize;
-
- private:
-  DISALLOW_IMPLICIT_CONSTRUCTORS(StackTraceFrame);
-};
 
 // List of builtin functions we want to identify to improve code
 // generation.
 //
 // Each entry has a name of a global object property holding an object
 // optionally followed by ".prototype", a name of a builtin function
 // on the object (the one the id is set for), and a label.
 //
 // Installation of ids for the selected builtin functions is handled
 // by the bootstrapper.
@@ skipping 4292 matching lines @@
     }
     return value;
   }
 };
 
 
 }  // NOLINT, false-positive due to second-order macros.
 }  // NOLINT, false-positive due to second-order macros.
 
 #endif  // V8_OBJECTS_H_