Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2252783007: Revert of Use a custom Struct for stack trace storage (Closed)

Created:
4 years, 4 months ago by jgruber
Modified:
4 years, 4 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Use a custom Struct for stack trace storage (patchset #4 id:60001 of https://codereview.chromium.org/2230953002/ ) Reason for revert: Performance regressions in Gameboy, Life, CodeLoad and others. See crbug.com/638210. Original issue's description: > Refactor data structures for simple stack traces > > Simple stack traces are captured through Isolate::CaptureSimpleStackTrace. > Captured frames are stored in a FixedArray, which in turn is stored as a > property (using a private symbol) on the error object itself. Actual formatting > of the textual stack trace is done lazily when the user reads the stack > property of the error object. > > This would involve many conversions back and forth between index-encoded raw > data (receiver, function, offset and code), JS CallSite objects, and C++ > CallSite objects. > > This commit refactors the C++ CallSite class into a Struct class called > StackTraceFrame, which is the new single point of truth frame information. > Isolate::CaptureSimpleStackTrace stores an array of StackTraceFrames, and JS > CallSite objects (now created only when the user specifies custom stack trace > formatting through Error.prepareStackTrace) internally only store a reference > to a StackTraceFrame. > > BUG= > > Committed: https://crrev.com/b4c1aefb9c369f1a33a6ca94a5de9b06ea4bf5c4 > Cr-Commit-Position: refs/heads/master@{#38645} TBR=yangguo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/6b7493a4d801af44e0f02c30b7e34cf9beb5ad1e Cr-Commit-Position: refs/heads/master@{#38700}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+996 lines, -976 lines) Patch
M include/v8.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins/builtins-callsite.cc View 2 chunks +92 lines, -39 lines 0 comments Download
M src/execution.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/execution.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M src/factory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/factory.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/heap-symbols.h View 1 chunk +7 lines, -1 line 0 comments Download
M src/isolate.cc View 10 chunks +117 lines, -109 lines 0 comments Download
M src/messages.h View 2 chunks +44 lines, -0 lines 0 comments Download
M src/messages.cc View 5 chunks +694 lines, -64 lines 0 comments Download
M src/objects.h View 5 chunks +1 line, -85 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -610 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -23 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +9 lines, -14 lines 0 comments Download
M src/types.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
jgruber
Created Revert of Use a custom Struct for stack trace storage
4 years, 4 months ago (2016-08-18 08:01:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252783007/1
4 years, 4 months ago (2016-08-18 08:01:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 08:31:17 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 08:31:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b7493a4d801af44e0f02c30b7e34cf9beb5ad1e
Cr-Commit-Position: refs/heads/master@{#38700}

Powered by Google App Engine
This is Rietveld 408576698