content/browser/media/android/media_web_contents_observer_android.cc - Issue 2252783004: Implement MediaSession (metadata) per frame [NOT READY, HAS DEPENDENCY]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/android/media_web_contents_observer_android.cc

Issue 2252783004: Implement MediaSession (metadata) per frame [NOT READY, HAS DEPENDENCY] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/media/android/browser_media_session_manager_browsertest.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/media/android/media_web_contents_observer_android.cc

diff --git a/content/browser/media/android/media_web_contents_observer_android.cc b/content/browser/media/android/media_web_contents_observer_android.cc

index 4739ff72e436daf2e018942fcd4abd34cbc5780f..de02698c4bf04401f0793d384fb69e81f586c4fe 100644

--- a/content/browser/media/android/media_web_contents_observer_android.cc

+++ b/content/browser/media/android/media_web_contents_observer_android.cc

@@ -63,8 +63,8 @@ MediaWebContentsObserverAndroid::GetMediaSessionManager(

if (it != media_session_managers_.end())

return it->second;

- BrowserMediaSessionManager* manager =

- new BrowserMediaSessionManager(render_frame_host);

+ BrowserMediaSessionManager* manager = new BrowserMediaSessionManager(

+ render_frame_host, static_cast<WebContentsImpl*>(web_contents()));

media_session_managers_.set(render_frame_host, base::WrapUnique(manager));

return manager;

}