content/browser/android/web_contents_observer_proxy.h - Issue 2252783004: Implement MediaSession (metadata) per frame [NOT READY, HAS DEPENDENCY]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/web_contents_observer_proxy.h

Issue 2252783004: Implement MediaSession (metadata) per frame [NOT READY, HAS DEPENDENCY] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: minor fixes Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/media/android/browser_media_session_manager.h » ('j') | content/browser/media/android/browser_media_session_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/web_contents_observer_proxy.h

diff --git a/content/browser/android/web_contents_observer_proxy.h b/content/browser/android/web_contents_observer_proxy.h

index 40fceb476e8e34a49a66990155955885010c4060..377e55a03bd68179de3110d9d7994e413daafe48 100644

--- a/content/browser/android/web_contents_observer_proxy.h

+++ b/content/browser/android/web_contents_observer_proxy.h

@@ -9,6 +9,7 @@

#include "base/android/jni_weak_ref.h"

#include "base/macros.h"

+#include "base/optional.h"

whywhat 2016/09/13 16:23:26 nit: looks like an accidental change; should be in

Zhiqiang Zhang (Slow) 2016/09/13 18:51:52 Done.

#include "base/process/kill.h"

#include "content/browser/web_contents/web_contents_impl.h"

#include "content/public/browser/reload_type.h"