Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2252763002: [OriginTrialEnabled] Add layout tests for static attribute (Closed)

Created:
4 years, 4 months ago by chasej
Modified:
4 years, 4 months ago
Reviewers:
haraken, iclelland
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org, chasej+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[OriginTrialEnabled] Add layout tests for static attribute Final cleanup and tests for supporting [OriginTrialEnabled] applied directly to a partial interface. BUG=585656 Committed: https://crrev.com/fa0f9b6f0fa97e0270eed27c38e7f32545efd87f Cr-Commit-Position: refs/heads/master@{#412527}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Messages

Total messages: 19 (11 generated)
chasej
haraken, iclelland, please take a look.
4 years, 4 months ago (2016-08-16 19:15:46 UTC) #5
iclelland
https://codereview.chromium.org/2252763002/diff/1/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origin_trials.js File third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origin_trials.js (right): https://codereview.chromium.org/2252763002/diff/1/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origin_trials.js#newcode116 third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origin_trials.js:116: assert_true(internalsInterface.frobulateStatic, 'Static attribute should return boolean value'); Should this ...
4 years, 4 months ago (2016-08-16 19:20:08 UTC) #6
chasej
https://codereview.chromium.org/2252763002/diff/1/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origin_trials.js File third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origin_trials.js (right): https://codereview.chromium.org/2252763002/diff/1/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origin_trials.js#newcode116 third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origin_trials.js:116: assert_true(internalsInterface.frobulateStatic, 'Static attribute should return boolean value'); On 2016/08/16 ...
4 years, 4 months ago (2016-08-16 20:03:52 UTC) #9
iclelland
LGTM
4 years, 4 months ago (2016-08-16 23:04:27 UTC) #12
haraken
LGTM
4 years, 4 months ago (2016-08-17 01:03:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252763002/20001
4 years, 4 months ago (2016-08-17 13:49:22 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 14:50:22 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 14:52:21 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fa0f9b6f0fa97e0270eed27c38e7f32545efd87f
Cr-Commit-Position: refs/heads/master@{#412527}

Powered by Google App Engine
This is Rietveld 408576698