Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Issue 2252743002: Revert of Add MemoryCoordinatorClient (Closed)

Created:
4 years, 4 months ago by boliu
Modified:
4 years, 4 months ago
Reviewers:
haraken, esprehn, tasak, bashi
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-dom_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, eae+blinkwatch, gavinp+loader_chromium.org, jam, Nate Chapin, kinuko+watch, loading-reviews+fetch_chromium.org, mlamouri+watch-content_chromium.org, rwlbuis, sof, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add MemoryCoordinatorClient (patchset #3 id:40001 of https://codereview.chromium.org/2230433002/ ) Reason for revert: Null pointer crash. See crbug.com/638274 BUG=638274 Original issue's description: > Add MemoryCoordinatorClient > > Also move MemoryCoordinator from core/dom to platform/. This is a preparation for experimenting purge and suspend [1,2]. > > [1] https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJvI/edit > [2] https://codereview.chromium.org/2130683002/ > > Committed: https://crrev.com/75ce9c3e2c15f2df215184026162dc505df37e4b > Cr-Commit-Position: refs/heads/master@{#412171} TBR=esprehn@chromium.org,haraken@chromium.org,tasak@google.com,bashi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/1007faf2a13282060f7227e8cb6ea96981c6f9eb Cr-Commit-Position: refs/heads/master@{#412276}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -194 lines) Patch
M content/renderer/render_thread_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/MemoryCoordinator.h View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/MemoryCoordinator.cpp View 1 chunk +43 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/MemoryCache.h View 3 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/MemoryCache.cpp View 3 chunks +0 lines, -8 lines 0 comments Download
D third_party/WebKit/Source/platform/MemoryCoordinator.h View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/WebKit/Source/platform/MemoryCoordinator.cpp View 1 chunk +0 lines, -74 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/platform/exported/WebMemoryCoordinator.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
A third_party/WebKit/Source/web/WebMemoryCoordinator.cpp View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/web.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 2 chunks +1 line, -1 line 0 comments Download
D third_party/WebKit/public/platform/WebMemoryCoordinator.h View 1 chunk +0 lines, -26 lines 0 comments Download
A third_party/WebKit/public/web/WebMemoryCoordinator.h View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
boliu
Created Revert of Add MemoryCoordinatorClient
4 years, 4 months ago (2016-08-16 17:29:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252743002/1
4 years, 4 months ago (2016-08-16 17:30:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 17:31:08 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1007faf2a13282060f7227e8cb6ea96981c6f9eb Cr-Commit-Position: refs/heads/master@{#412276}
4 years, 4 months ago (2016-08-16 17:33:32 UTC) #7
haraken
4 years, 4 months ago (2016-08-16 22:54:14 UTC) #8
Message was sent while issue was closed.
LGTM to revert.

Powered by Google App Engine
This is Rietveld 408576698