Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2252723008:
Add a custom error message in EG WaitUtil (Closed)
DescriptionAdd a custom error message in EG WaitUtil
This CL adds a parameter to the WaitUntilCondition of Earl Grey wait_util to
display a more explicit custom error message if the condition is not met at
the end of the timeout.
BUG=none
Committed: https://crrev.com/b594d3fdac4315b40808b2b74fd5a1d88db1ee10
Cr-Commit-Position: refs/heads/master@{#413416}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Change argument order #Patch Set 3 : Rebase #
Messages
Total messages: 22 (13 generated)
gambard@chromium.org changed reviewers: + baxley@chromium.org
PTAL.
lgtm https://codereview.chromium.org/2252723008/diff/1/ios/testing/earl_grey/wait_... File ios/testing/earl_grey/wait_util.h (right): https://codereview.chromium.org/2252723008/diff/1/ios/testing/earl_grey/wait_... ios/testing/earl_grey/wait_util.h:27: bool (^condition)(void), nit: what do you think about moving the block parameter to be the last arg? That's Apple's guidance, though I didn't see anything glancing at Google's guide. Feel free to push back if you disagree, or find something elsewhere.
The CQ bit was checked by gambard@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from baxley@chromium.org Link to the patchset: https://codereview.chromium.org/2252723008/#ps20001 (title: "Change argument order")
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2257093002 Patch 40001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
Description was changed from ========== Add a custom error message in EG WaitUtil This CL adds a parameter to the WaitUntilCondition of Earl Grey wait_util to display a more explicit custom error message if the condition is not met at the end of the timeout. BUG=none ========== to ========== Add a custom error message in EG WaitUtil This CL adds a parameter to the WaitUntilCondition of Earl Grey wait_util to display a more explicit custom error message if the condition is not met at the end of the timeout. BUG=none NO_DEPENDENCY_CHECKS=true ==========
The CQ bit was checked by gambard@chromium.org
Thanks! https://codereview.chromium.org/2252723008/diff/1/ios/testing/earl_grey/wait_... File ios/testing/earl_grey/wait_util.h (right): https://codereview.chromium.org/2252723008/diff/1/ios/testing/earl_grey/wait_... ios/testing/earl_grey/wait_util.h:27: bool (^condition)(void), On 2016/08/22 03:55:01, baxley wrote: > nit: what do you think about moving the block parameter to be the last arg? > That's Apple's guidance, though I didn't see anything glancing at Google's > guide. Feel free to push back if you disagree, or find something elsewhere. Done.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
Description was changed from ========== Add a custom error message in EG WaitUtil This CL adds a parameter to the WaitUntilCondition of Earl Grey wait_util to display a more explicit custom error message if the condition is not met at the end of the timeout. BUG=none NO_DEPENDENCY_CHECKS=true ========== to ========== Add a custom error message in EG WaitUtil This CL adds a parameter to the WaitUntilCondition of Earl Grey wait_util to display a more explicit custom error message if the condition is not met at the end of the timeout. BUG=none ==========
The CQ bit was checked by gambard@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from baxley@chromium.org Link to the patchset: https://codereview.chromium.org/2252723008/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add a custom error message in EG WaitUtil This CL adds a parameter to the WaitUntilCondition of Earl Grey wait_util to display a more explicit custom error message if the condition is not met at the end of the timeout. BUG=none ========== to ========== Add a custom error message in EG WaitUtil This CL adds a parameter to the WaitUntilCondition of Earl Grey wait_util to display a more explicit custom error message if the condition is not met at the end of the timeout. BUG=none ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Add a custom error message in EG WaitUtil This CL adds a parameter to the WaitUntilCondition of Earl Grey wait_util to display a more explicit custom error message if the condition is not met at the end of the timeout. BUG=none ========== to ========== Add a custom error message in EG WaitUtil This CL adds a parameter to the WaitUntilCondition of Earl Grey wait_util to display a more explicit custom error message if the condition is not met at the end of the timeout. BUG=none Committed: https://crrev.com/b594d3fdac4315b40808b2b74fd5a1d88db1ee10 Cr-Commit-Position: refs/heads/master@{#413416} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/b594d3fdac4315b40808b2b74fd5a1d88db1ee10 Cr-Commit-Position: refs/heads/master@{#413416}
Message was sent while issue was closed.
Patchset #4 (id:60001) has been deleted |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
