Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2252723005: Add an UMA for file types selected when Quick View is launched. (Closed)

Created:
4 years, 4 months ago by oka
Modified:
4 years, 4 months ago
Reviewers:
fukino, Steven Holte
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an UMA for file types selected when Quick View is launched. BUG=627697 TEST=opened a file and moved to the next with <Right> and checked chrome://histograms. Confirmed 1 FileBrowser.QuickView.FileTypeOnLaunch is exported and 2 FileBrowser.QuickView.FileType are exported. Committed: https://crrev.com/621feebe12cd4625776cd1a9099acd1c22a176de Cr-Commit-Position: refs/heads/master@{#412761}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/quick_view_uma.js View 2 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
oka
PTAL. asvitkine@ for tools/metrics/histograms/histograms.xml. Thanks.
4 years, 4 months ago (2016-08-17 06:11:23 UTC) #2
oka
+holte@ for tools/metrics/histograms/histograms.xml. (because reviewer name of Alexei contains 'very slow'.) Thanks.
4 years, 4 months ago (2016-08-17 06:15:09 UTC) #5
Steven Holte
lgtm
4 years, 4 months ago (2016-08-17 21:58:31 UTC) #6
oka
On 2016/08/17 21:58:31, Steven Holte wrote: > lgtm Thank you Steven.
4 years, 4 months ago (2016-08-18 01:57:25 UTC) #8
fukino
lgtm with a request. Please be more descriptive on TEST= line (you checked chrome://histograms or ...
4 years, 4 months ago (2016-08-18 04:39:22 UTC) #9
oka
On 2016/08/18 04:39:22, fukino wrote: > lgtm with a request. > > Please be more ...
4 years, 4 months ago (2016-08-18 05:49:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252723005/1
4 years, 4 months ago (2016-08-18 05:49:20 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 08:09:45 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 08:13:29 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/621feebe12cd4625776cd1a9099acd1c22a176de
Cr-Commit-Position: refs/heads/master@{#412761}

Powered by Google App Engine
This is Rietveld 408576698