Fix fragmented image signature handling

third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp

 /*
  * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved.
  *
  *  This library is free software; you can redistribute it and/or
  *  modify it under the terms of the GNU Library General Public
  *  License as published by the Free Software Foundation; either
  *  version 2 of the License, or (at your option) any later version.
  *
  *  This library is distributed in the hope that it will be useful,
  *  but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 89 matching lines @@
     case SniffResult::BMP:
         return wrapUnique(new BMPImageDecoder(alphaOption, colorOptions, maxDecodedBytes));
     case SniffResult::InsufficientData:
     case SniffResult::Invalid:
         return nullptr;
     }
     NOTREACHED();
     return nullptr;
 }
 
+namespace {

[Peter Kasting, 2016/08/16 20:12:25]

Instead of adding all this, why not just use FastSharedBufferReader, which seems
like it's designed to do pretty much exactly what you want here?

[f(malita), 2016/08/16 21:54:03]

I wasn't familiar with FastSharedBufferReader, good idea.

Done.

The only downside is an extra SegmentReader allocation, but, since ImageDecoder
stores a SegmentReader anyway, I think we can get rid of this temp allocation by
refactoring/fusing these methods with the factory.  Planning to look at that in
a follow-up.

+
+constexpr size_t kLongestSignatureLength = sizeof("RIFF????WEBPVP") - 1;
+static_assert(kLongestSignatureLength == 14, "kLongestSignatureLength mismatch");
+
+// Offers contiguous access to the first LEN bytes in the buffer.
+// If the first segment is large enough to hold all the requested data, we use a pointer to
+// the actual segment data.
+// Otherwise, we copy/consolidate the data in a local buffer.
+template <typename T, size_t LEN>
+class SpeculativeSegmentReader {
+    STACK_ALLOCATED();
+public:
+    SpeculativeSegmentReader(const T& data, size_t (*accessSegment)(const T&, const char*&, size_t))
+    {
+        m_dataLen = accessSegment(data, m_data, 0);
+        if (!m_dataLen || m_dataLen >= LEN) {
+            // We either don't have any data, or the first segment is large enough.
+            // Either way, we don't need a copy: just use the actual/contiguous segment data.
+            return;
+        }
+
+        // The signature is fragmented: we need to make a copy.
+        std::copy(m_data, m_data + m_dataLen, m_buffer);
+        m_data = m_buffer;
+
+        do {
+            const char* segmentData;
+            const size_t segmentLen = accessSegment(data, segmentData, m_dataLen);
+            if (!segmentLen)
+                break;
+            const size_t usableLen = std::min(segmentLen, LEN - m_dataLen);
+            std::copy(segmentData, segmentData + usableLen, m_buffer + m_dataLen);
+            m_dataLen += usableLen;
+        } while (m_dataLen < LEN);
+    }
+
+    const char* data() const { return m_data; }
+    size_t dataLen() const { return m_dataLen; }
+
+private:
+    const char* m_data;
+    size_t m_dataLen;
+    char m_buffer[LEN];
+};
+
+} // anonymous ns
+
 ImageDecoder::SniffResult ImageDecoder::determineImageType(const char* contents, size_t length)
 {
-    const size_t longestSignatureLength = sizeof("RIFF????WEBPVP") - 1;
-    DCHECK_EQ(14u, longestSignatureLength);
-
-    if (length < longestSignatureLength)
+    if (length < kLongestSignatureLength)
         return SniffResult::InsufficientData;
     if (matchesJPEGSignature(contents))
         return SniffResult::JPEG;
     if (matchesPNGSignature(contents))
         return SniffResult::PNG;
     if (matchesGIFSignature(contents))
         return SniffResult::GIF;
     if (matchesWebPSignature(contents))
         return SniffResult::WEBP;
     if (matchesICOSignature(contents) || matchesCURSignature(contents))
         return SniffResult::ICO;
     if (matchesBMPSignature(contents))
         return SniffResult::BMP;
     return SniffResult::Invalid;
 }
 
 ImageDecoder::SniffResult ImageDecoder::determineImageType(const SharedBuffer& data)
 {
-    const char* contents;
-    const size_t length = data.getSomeData<size_t>(contents);
-    return determineImageType(contents, length);
+    const SpeculativeSegmentReader<SharedBuffer, kLongestSignatureLength> sniffer(data,
+        [] (const SharedBuffer& data, const char*& segmentData, size_t offset) -> size_t {
+            return data.getSomeData<size_t>(segmentData, offset);
+        });
+    return determineImageType(sniffer.data(), sniffer.dataLen());
 }
 
 ImageDecoder::SniffResult ImageDecoder::determineImageType(const SegmentReader& data)
 {
-    const char* contents;
-    const size_t length = data.getSomeData(contents, 0);
-    return determineImageType(contents, length);
+    const SpeculativeSegmentReader<SegmentReader, kLongestSignatureLength> sniffer(data,
+        [] (const SegmentReader& data, const char*& segmentData, size_t offset) -> size_t {
+            return data.getSomeData(segmentData, offset);
+        });
+    return determineImageType(sniffer.data(), sniffer.dataLen());
 }
 
 size_t ImageDecoder::frameCount()
 {
     const size_t oldSize = m_frameBufferCache.size();
     const size_t newSize = decodeFrameCount();
     if (oldSize != newSize) {
         m_frameBufferCache.resize(newSize);
         for (size_t i = oldSize; i < newSize; ++i) {
             m_frameBufferCache[i].setPremultiplyAlpha(m_premultiplyAlpha);
@@ skipping 251 matching lines @@
         return;
 
     qcms_data_type dataFormat = hasAlpha ? QCMS_DATA_RGBA_8 : QCMS_DATA_RGB_8;
 
     // FIXME: Don't force perceptual intent if the image profile contains an intent.
     m_sourceToOutputDeviceColorTransform.reset(qcms_transform_create(inputProfile.get(), dataFormat, gTargetColorProfile, QCMS_DATA_RGBA_8, QCMS_INTENT_PERCEPTUAL));
 #endif // USE(QCMSLIB)
 }
 
 } // namespace blink