ash:Shelf Overflow Button

ash/launcher/launcher_view.cc

Index: ash/launcher/launcher_view.cc
diff --git a/ash/launcher/launcher_view.cc b/ash/launcher/launcher_view.cc
index ea027f6f338f662ad0cd7137d6d7f962a4d96620..2e402992e0f24b70230698fc621e4163fdf97259 100644
--- a/ash/launcher/launcher_view.cc
+++ b/ash/launcher/launcher_view.cc
@@ -466,6 +466,13 @@ void LauncherView::OnShelfAlignmentChanged() {
     overflow_bubble_->Hide();
 }
 
+void LauncherView::SchedulePaintForAllButtons() {
+  for (int i=0; i >= first_visible_index_ && i <= last_visible_index_; ++i)

[James Cook, 2013/08/07 18:23:13]

spaces around =, and should i start at first_visible_index_?

[Harry McCleave, 2013/08/07 22:50:59]

Spacing done, first_visible_index and last_visible_index could both be -1 if no
items are available thus starting at 0 to ensure no look-up at index -1, I added
the -1 check as a conditional outside of the loop for readability (and a very
minuscule performance improvement).

[James Cook, 2013/08/07 23:22:05]

Much easier to understand, thanks.

+    view_model_->view_at(i)->SchedulePaint();
+  if (overflow_button_ && overflow_button_->visible())
+    overflow_button_->SchedulePaint();
+}
+
 gfx::Rect LauncherView::GetIdealBoundsOfItemIcon(LauncherID id) {
   int index = model_->ItemIndexByID(id);
   if (index == -1 || (index > last_visible_index_ &&