ash:Shelf Overflow Button

ash/launcher/launcher_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/launcher/launcher_view.h"
 
 #include <algorithm>
 
 #include "ash/ash_constants.h"
 #include "ash/ash_switches.h"
@@ skipping 448 matching lines @@
               views::ImageButton::ALIGN_BOTTOM));
     }
     if (i >= first_visible_index_ && i <= last_visible_index_)
       view_model_->view_at(i)->Layout();
   }
   tooltip_->UpdateArrow();
   if (overflow_bubble_)
     overflow_bubble_->Hide();
 }
 
+void LauncherView::SchedulePaintForAllButtons() {
+  for (int i=0; i >= first_visible_index_ && i <= last_visible_index_; ++i)

[James Cook, 2013/08/07 18:23:13]

spaces around =, and should i start at first_visible_index_?

[Harry McCleave, 2013/08/07 22:50:59]

Spacing done, first_visible_index and last_visible_index could both be -1 if no
items are available thus starting at 0 to ensure no look-up at index -1, I added
the -1 check as a conditional outside of the loop for readability (and a very
minuscule performance improvement).

[James Cook, 2013/08/07 23:22:05]

Much easier to understand, thanks.

+    view_model_->view_at(i)->SchedulePaint();
+  if (overflow_button_ && overflow_button_->visible())
+    overflow_button_->SchedulePaint();
+}
+
 gfx::Rect LauncherView::GetIdealBoundsOfItemIcon(LauncherID id) {
   int index = model_->ItemIndexByID(id);
   if (index == -1 || (index > last_visible_index_ &&
                       index < model_->FirstPanelIndex()))
     return gfx::Rect();
   const gfx::Rect& ideal_bounds(view_model_->ideal_bounds(index));
   DCHECK_NE(TYPE_APP_LIST, model_->items()[index].type);
   LauncherButton* button =
       static_cast<LauncherButton*>(view_model_->view_at(index));
   gfx::Rect icon_bounds = button->GetIconBounds();
@@ skipping 1227 matching lines @@
 bool LauncherView::ShouldShowTooltipForView(const views::View* view) const {
   if (view == GetAppListButtonView() &&
       Shell::GetInstance()->GetAppListWindow())
     return false;
   const LauncherItem* item = LauncherItemForView(view);
   return (!item || delegate_->ShouldShowTooltip(*item));
 }
 
 }  // namespace internal
 }  // namespace ash