Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2769)

Unified Diff: ash/wm/window_cycle_event_filter_aura.cc

Issue 2252673002: Don't handle the tab press event in the window cycle event filter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge and fix test for new alt+tab UI. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/window_cycle_controller_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/window_cycle_event_filter_aura.cc
diff --git a/ash/wm/window_cycle_event_filter_aura.cc b/ash/wm/window_cycle_event_filter_aura.cc
index 69bf11bc0105d5c1474d320a39fbc362c79e2486..4dea0ade0d44d13a15d8f69a8abf4bd2f643f6a9 100644
--- a/ash/wm/window_cycle_event_filter_aura.cc
+++ b/ash/wm/window_cycle_event_filter_aura.cc
@@ -20,9 +20,13 @@ WindowCycleEventFilterAura::~WindowCycleEventFilterAura() {
}
void WindowCycleEventFilterAura::OnKeyEvent(ui::KeyEvent* event) {
- // Until the alt key is released, all key events are handled by this window
- // cycle controller: https://crbug.com/340339.
- event->StopPropagation();
+ // Until the alt key is released, all key events except the tab press (which
+ // is handled by the accelerator controller to call Step) are handled by this
+ // window cycle controller: https://crbug.com/340339.
+ if (event->key_code() != ui::VKEY_TAB ||
+ event->type() != ui::ET_KEY_PRESSED) {
+ event->StopPropagation();
+ }
// Views uses VKEY_MENU for both left and right Alt keys.
if (event->key_code() == ui::VKEY_MENU &&
event->type() == ui::ET_KEY_RELEASED) {
« no previous file with comments | « ash/wm/window_cycle_controller_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698