Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Issue 2252653002: Avoid accessing out of range in ScriptStreamer (Closed)

Created:
4 years, 4 months ago by peria
Modified:
4 years, 4 months ago
Reviewers:
haraken, tzik, Yuki, marja
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoids accessing out of range in ScriptStreamer If resource buffer's first chunk is shorter than BOM length, ScriptStreamer accesses out of range. BUG=634935 Committed: https://crrev.com/be99583f3e0d6ebf59ca413a5c2fa09d535a05fc Cr-Commit-Position: refs/heads/master@{#412252}

Patch Set 1 : Rename variables #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -27 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp View 1 chunk +36 lines, -27 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
peria
PTL
4 years, 4 months ago (2016-08-16 13:21:21 UTC) #5
haraken
LGTM
4 years, 4 months ago (2016-08-16 13:30:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252653002/20001
4 years, 4 months ago (2016-08-16 13:33:54 UTC) #8
Yuki
lgtm
4 years, 4 months ago (2016-08-16 14:22:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 4 months ago (2016-08-16 15:44:26 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 15:46:57 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be99583f3e0d6ebf59ca413a5c2fa09d535a05fc
Cr-Commit-Position: refs/heads/master@{#412252}

Powered by Google App Engine
This is Rietveld 408576698