Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2252633002: Polymer WebUI: Enable native CSS custom properties (Closed)

Created:
4 years, 4 months ago by tsergeant
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam, michaelpg
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-elements_chromium.org, oshima+watch_chromium.org, michaelpg, calamity
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Polymer WebUI: Enable native CSS custom properties This enables native custom properties, which are supported in Polymer 1.6. This provides a performance improvement of about 4% for the load time of MD History (690ms vs 720ms, n=5), and should provide a similar improvement to all Polymer-based pages. BUG=629710 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/af78369e67aadb067975e87f9aab642e80e0c172 Cr-Commit-Position: refs/heads/master@{#412396}

Patch Set 1 #

Patch Set 2 : Simplify search field change #

Patch Set 3 : Revulcanize downloads #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -22 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 1 2 2 chunks +33 lines, -15 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_search_field/cr_search_field.css View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/webui/resources/js/polymer_config.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
tsergeant
PTAL. We should land this sooner rather than later if we want to pick up ...
4 years, 4 months ago (2016-08-16 08:38:49 UTC) #7
tsergeant
On 2016/08/16 08:38:49, tsergeant wrote: > PTAL. > > We should land this sooner rather ...
4 years, 4 months ago (2016-08-16 10:25:05 UTC) #12
michaelpg
lgtm as far as settings goes
4 years, 4 months ago (2016-08-16 22:28:00 UTC) #14
Dan Beam
lgtm
4 years, 4 months ago (2016-08-16 23:34:57 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252633002/40001
4 years, 4 months ago (2016-08-16 23:49:20 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-17 00:27:50 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 00:29:20 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/af78369e67aadb067975e87f9aab642e80e0c172
Cr-Commit-Position: refs/heads/master@{#412396}

Powered by Google App Engine
This is Rietveld 408576698