Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: scripts/slave/recipe_modules/chromium_android/resources/template/main.html

Issue 2252603002: Created a line of summary and enabled suite name onclick function. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium_android/resources/template/main.html
diff --git a/scripts/slave/recipe_modules/chromium_android/resources/template/main.html b/scripts/slave/recipe_modules/chromium_android/resources/template/main.html
index 327706f5d109941e86b88ac9141e71c1f5a99b84..0a836a8983d8ba78e3da6793bd88f85582082ac5 100644
--- a/scripts/slave/recipe_modules/chromium_android/resources/template/main.html
+++ b/scripts/slave/recipe_modules/chromium_android/resources/template/main.html
@@ -35,6 +35,31 @@
}
</style>
<script type="text/javascript">
+ function showTestsOfOneSuiteOnly(suite_name) {
+ var testTableRows = document.getElementById('test_table')
+ .getElementsByClassName('body')[0].getElementsByTagName('tr');
the real yoland 2016/08/18 20:44:56 nit: I believe you can get by tag name with 'tbody
BigBossZhiling 2016/08/23 17:38:51 Done.
+ var testCasePathClass = 0
the real yoland 2016/08/18 20:44:56 nit: ;
+ Array.prototype.slice.call(testTableRows)
+ .forEach(function(row, _) {
the real yoland 2016/08/18 20:44:56 You don't need underscore just `function(row) {`
BigBossZhiling 2016/08/23 17:38:51 Done.
+ var testCasePath = row.getElementsByClassName(
the real yoland 2016/08/18 20:44:56 hmm, I think you should change these <tr> class na
BigBossZhiling 2016/08/23 17:38:51 Done.
+ testCasePathClass)[0].innerText.trim();
+ if (testCasePath.startsWith(suite_name)) {
+ row.style.display = 'table-row';
+ } else {
+ row.style.display = 'none';
+ }
+ })
+ }
+
+ function showAllTests() {
+ var testTableRows = document.getElementById('test_table')
+ .getElementsByClassName('body')[0].getElementsByTagName('tr');
+ Array.prototype.slice.call(testTableRows)
+ .forEach(function(row, _) {
the real yoland 2016/08/18 20:44:56 same, don't need '_'
BigBossZhiling 2016/08/23 17:38:51 Done.
+ row.style.display = 'table-row';
+ })
+ }
+
function sortByColumn(head) {
var tbody = head.parentNode.parentNode.nextElementSibling;
var rows = tbody.rows;

Powered by Google App Engine
This is Rietveld 408576698