Created a line of summary and enabled suite name onclick function.

Created a line of summary and enabled suite name onclick function.

In suite result table, added a summary line to show the number of all
tests run, all tests failed etc.

If a suite name is clicked, only tests inside that suite, will be shown
in testcase table. If 'TOTAL' is clicked in the summary line, tests in
all suites will be shown in testcase table.

BUG=

Committed: https://chromium.googlesource.com/chromium/tools/build/+/ecde496f342028076fcfe127b34955524824b477

[BigBossZhiling, 2016-08-16 01:52:24]

Description was changed from

==========
Created a line of summary and enabled suite name onclick function.

In suite result table, added a summary line to show the number of all
tests run, all tests failed etc.

If a suite name is clicked, only tests inside that suite, will be shown
in testcase table. If 'TOTAL' is clicked in the summary line, tests in
all suites will be shown in testcase table.

BUG=
==========

to

==========
Created a line of summary and enabled suite name onclick function.

In suite result table, added a summary line to show the number of all
tests run, all tests failed etc.

If a suite name is clicked, only tests inside that suite, will be shown
in testcase table. If 'TOTAL' is clicked in the summary line, tests in
all suites will be shown in testcase table.

BUG=
==========

[BigBossZhiling, 2016-08-16 01:52:24]

hzl@google.com changed reviewers:
+ jbudorick@chromium.org, yolandyan@chromium.org

[jbudorick, 2016-08-18 19:36:46]

On 2016/08/16 01:52:41, BigBossZhiling wrote:

deferring to yolandyan

[the real yoland, 2016-08-18 20:44:56]

https://codereview.chromium.org/2252603002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_android/resources/template/main.html
(right):

https://codereview.chromium.org/2252603002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_android/resources/template/main.html:40:
.getElementsByClassName('body')[0].getElementsByTagName('tr');
nit: I believe you can get by tag name with 'tbody' here, it's clearer.

https://codereview.chromium.org/2252603002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_android/resources/template/main.html:41:
var testCasePathClass = 0
nit: ;

https://codereview.chromium.org/2252603002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_android/resources/template/main.html:43:
.forEach(function(row, _) {
You don't need underscore just `function(row) {`

https://codereview.chromium.org/2252603002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_android/resources/template/main.html:44:
var testCasePath = row.getElementsByClassName(
hmm, I think you should change these <tr> class name from {{loop.index0}} to
something like {{tb_value.table_id}}-column-{{loop.index0}}, which the test
columns becomes "test-table-column-0", "test-table-column-2"
This way you don't do these getElementsByxxx to narrow down your target.

It's also clearer on what you are trying to get.

https://codereview.chromium.org/2252603002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_android/resources/template/main.html:58:
.forEach(function(row, _) {
same, don't need '_'

https://codereview.chromium.org/2252603002/diff/1/scripts/slave/recipe_module...
File
scripts/slave/recipe_modules/chromium_android/resources/test_results_presentation.py
(right):

https://codereview.chromium.org/2252603002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_android/resources/test_results_presentation.py:78:
'action': 'showTestsOfOneSuiteOnly(\'%s\');' % suite_name},
I think this is okay, but in general, it's a good practice to separate the data
rendering from the data presentation part, if you need add any more onclick
action through, you should consider complete do it through
`arr.forEach(function(el){el.addEventListener(...)})` in the javascript.

https://codereview.chromium.org/2252603002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_android/resources/test_results_presentation.py:107:
'table_id' : 'test_table',
nit: test-table
sorry, didn't notice this one
https://google.github.io/styleguide/htmlcssguide.xml?showone=ID_and_Class_Nam...

https://codereview.chromium.org/2252603002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_android/resources/test_results_presentation.py:117:
'table_id' : 'suite_table',
suite-table

[BigBossZhiling, 2016-08-23 17:38:51]

https://codereview.chromium.org/2252603002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_android/resources/template/main.html
(right):

https://codereview.chromium.org/2252603002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_android/resources/template/main.html:40:
.getElementsByClassName('body')[0].getElementsByTagName('tr');
On 2016/08/18 20:44:56, the real yoland wrote:
> nit: I believe you can get by tag name with 'tbody' here, it's clearer.

Done.

https://codereview.chromium.org/2252603002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_android/resources/template/main.html:43:
.forEach(function(row, _) {
On 2016/08/18 20:44:56, the real yoland wrote:
> You don't need underscore just `function(row) {`

Done.

https://codereview.chromium.org/2252603002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_android/resources/template/main.html:44:
var testCasePath = row.getElementsByClassName(
On 2016/08/18 20:44:56, the real yoland wrote:
> hmm, I think you should change these <tr> class name from {{loop.index0}} to
> something like {{tb_value.table_id}}-column-{{loop.index0}}, which the test
> columns becomes "test-table-column-0", "test-table-column-2"
> This way you don't do these getElementsByxxx to narrow down your target.
> 
> It's also clearer on what you are trying to get.

Done.

https://codereview.chromium.org/2252603002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_android/resources/template/main.html:58:
.forEach(function(row, _) {
On 2016/08/18 20:44:56, the real yoland wrote:
> same, don't need '_'

Done.

https://codereview.chromium.org/2252603002/diff/1/scripts/slave/recipe_module...
File
scripts/slave/recipe_modules/chromium_android/resources/test_results_presentation.py
(right):

https://codereview.chromium.org/2252603002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_android/resources/test_results_presentation.py:78:
'action': 'showTestsOfOneSuiteOnly(\'%s\');' % suite_name},
On 2016/08/18 20:44:56, the real yoland wrote:
> I think this is okay, but in general, it's a good practice to separate the
data
> rendering from the data presentation part, if you need add any more onclick
> action through, you should consider complete do it through
> `arr.forEach(function(el){el.addEventListener(...)})` in the javascript.

Done.

https://codereview.chromium.org/2252603002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_android/resources/test_results_presentation.py:107:
'table_id' : 'test_table',
On 2016/08/18 20:44:56, the real yoland wrote:
> nit: test-table
> sorry, didn't notice this one
>
https://google.github.io/styleguide/htmlcssguide.xml?showone=ID_and_Class_Nam...

Done.

[the real yoland, 2016-08-23 19:56:05]

lgtm with nits

https://codereview.chromium.org/2252603002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_android/resources/template/main.html
(right):

https://codereview.chromium.org/2252603002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/resources/template/main.html:50:
})
nit: 
    }
);

https://codereview.chromium.org/2252603002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/resources/template/main.html:59:
})
nit: 
    }
);

https://codereview.chromium.org/2252603002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/resources/template/main.html:143:
.forEach(function(summary_total) {
nit: summaryTotal

https://codereview.chromium.org/2252603002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/resources/template/main.html:153:
.forEach(function(suite_name) {
nit: suiteName

[BigBossZhiling, 2016-08-23 22:20:24]

https://codereview.chromium.org/2252603002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_android/resources/template/main.html
(right):

https://codereview.chromium.org/2252603002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/resources/template/main.html:50:
})
On 2016/08/23 19:56:04, the real yoland wrote:
> nit: 
>     }
> );

Done.

https://codereview.chromium.org/2252603002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/resources/template/main.html:59:
})
On 2016/08/23 19:56:04, the real yoland wrote:
> nit: 
>     }
> );

Done.

https://codereview.chromium.org/2252603002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/resources/template/main.html:143:
.forEach(function(summary_total) {
On 2016/08/23 19:56:05, the real yoland wrote:
> nit: summaryTotal

Done.

https://codereview.chromium.org/2252603002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/resources/template/main.html:153:
.forEach(function(suite_name) {
On 2016/08/23 19:56:05, the real yoland wrote:
> nit: suiteName

Done.

[jbudorick, 2016-08-23 22:34:39]

lgtm

[BigBossZhiling, 2016-08-24 17:32:53]

The CQ bit was checked by hzl@google.com

[BigBossZhiling, 2016-08-24 17:32:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
yolandyan@chromium.org
Link to the patchset: https://codereview.chromium.org/2252603002/#ps40001
(title: "fixes")

[commit-bot: I haz the power, 2016-08-24 17:33:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 17:37:42]

Description was changed from

==========
Created a line of summary and enabled suite name onclick function.

In suite result table, added a summary line to show the number of all
tests run, all tests failed etc.

If a suite name is clicked, only tests inside that suite, will be shown
in testcase table. If 'TOTAL' is clicked in the summary line, tests in
all suites will be shown in testcase table.

BUG=
==========

to

==========
Created a line of summary and enabled suite name onclick function.

In suite result table, added a summary line to show the number of all
tests run, all tests failed etc.

If a suite name is clicked, only tests inside that suite, will be shown
in testcase table. If 'TOTAL' is clicked in the summary line, tests in
all suites will be shown in testcase table.

BUG=

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/ecde496f342028076fcf...
==========

[commit-bot: I haz the power, 2016-08-24 17:37:43]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/ecde496f342028076fcf...