Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2252573002: Implement a replacement for FileBasedSource (and _MemoryFileSource) (Closed)

Created:
4 years, 4 months ago by Brian Wilkerson
Modified:
4 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement a replacement for FileBasedSource (and _MemoryFileSource) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/edb847ab42b8319061c7b96229001b6edcfa1e84

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -5 lines) Patch
A pkg/analyzer/lib/src/source/source_resource.dart View 1 chunk +142 lines, -0 lines 4 comments Download
A pkg/analyzer/test/src/source/source_resource_test.dart View 1 chunk +214 lines, -0 lines 0 comments Download
A + pkg/analyzer/test/src/source/test_all.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
4 years, 4 months ago (2016-08-16 00:32:23 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2252573002/diff/1/pkg/analyzer/lib/src/source/source_resource.dart File pkg/analyzer/lib/src/source/source_resource.dart (right): https://codereview.chromium.org/2252573002/diff/1/pkg/analyzer/lib/src/source/source_resource.dart#newcode94 pkg/analyzer/lib/src/source/source_resource.dart:94: _encoding = uri.toString(); This can be simplified with ...
4 years, 4 months ago (2016-08-16 00:54:26 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2252573002/diff/1/pkg/analyzer/lib/src/source/source_resource.dart File pkg/analyzer/lib/src/source/source_resource.dart (right): https://codereview.chromium.org/2252573002/diff/1/pkg/analyzer/lib/src/source/source_resource.dart#newcode94 pkg/analyzer/lib/src/source/source_resource.dart:94: _encoding = uri.toString(); done https://codereview.chromium.org/2252573002/diff/1/pkg/analyzer/lib/src/source/source_resource.dart#newcode102 pkg/analyzer/lib/src/source/source_resource.dart:102: _absolutePath = file.path; ...
4 years, 4 months ago (2016-08-16 13:21:28 UTC) #4
Brian Wilkerson
4 years, 4 months ago (2016-08-16 15:00:01 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
edb847ab42b8319061c7b96229001b6edcfa1e84 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698