Chromium Code Reviews Chromium Code Reviews
Issue 2252553002:
Add cs-base-url, store_tombstones, master_name for android inst tests. (Closed)
Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master| Index: scripts/slave/recipe_modules/chromium_android/api.py |
| diff --git a/scripts/slave/recipe_modules/chromium_android/api.py b/scripts/slave/recipe_modules/chromium_android/api.py |
| index c5aaf39e75a1cffe99a208887aaf3c6d1c26b949..16e48a4893f80917fc040e1b9436e63261d5dd36 100644 |
| --- a/scripts/slave/recipe_modules/chromium_android/api.py |
| +++ b/scripts/slave/recipe_modules/chromium_android/api.py |
| @@ -850,6 +850,8 @@ class AndroidApi(recipe_api.RecipeApi): |
| device_flags=None, |
| wrapper_script_suite_name=None, |
| result_details=False, |
| + master_name=None, |
|
jbudorick
2016/08/17 04:15:28
Remove this argument.
BigBossZhiling
2016/08/17 22:38:27
Done.
|
| + cs_base_url=None, |
| **kwargs): |
| args = [ |
| '--blacklist-file', self.blacklist_file, |
| @@ -912,13 +914,18 @@ class AndroidApi(recipe_api.RecipeApi): |
| with self.m.step.nest('process results for %s' % step_name): |
| try: |
| details_html = details_dir.join('details.html') |
| + presentation_args = ['--json-file', |
| + json_results_file, |
| + '--html-file', |
| + details_html] |
| + if master_name: |
| + presentation_args.extend(['--master-name', master_name]) |
|
jbudorick
2016/08/17 04:15:28
Just use self.m.properties.get('mastername') as ma
BigBossZhiling
2016/08/17 22:38:27
Done.
|
| + if cs_base_url: |
| + presentation_args.extend(['--cs-base-url', cs_base_url]) |
| self.m.python( |
| 'Generate Result Details', |
| self.resource('test_results_presentation.py'), |
| - args=['--json-file', |
| - json_results_file, |
| - '--html-file', |
| - details_html]) |
| + args=presentation_args) |
| details_list = self.m.file.read( |
| 'Read detail.html', |
| details_html, |
